brigadier icon indicating copy to clipboard operation
brigadier copied to clipboard
verified publisher icon Mojang

Add missing calls to fail() when exceptions are expected to be thrown

Open Pokechu22 opened this issue 4 years ago • 1 comments

Fixes #106. Without this, the test could pass if no exception is thrown, in addition to the wanted result of a matching exception being thrown.

fail() is now called before any catch in test code, as verified by grep -B1 -r catch src/test/java: 
src/test/java/com/mojang/brigadier/arguments/DoubleArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/DoubleArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/DoubleArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/DoubleArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/FloatArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/FloatArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/FloatArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/FloatArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/IntegerArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/IntegerArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/IntegerArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/IntegerArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/LongArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/LongArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/arguments/LongArgumentTypeTest.java-            fail();
src/test/java/com/mojang/brigadier/arguments/LongArgumentTypeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java-            fail();
src/test/java/com/mojang/brigadier/CommandDispatcherTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/StringReaderTest.java-            fail();
src/test/java/com/mojang/brigadier/StringReaderTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/tree/LiteralCommandNodeTest.java-            fail();
src/test/java/com/mojang/brigadier/tree/LiteralCommandNodeTest.java:        } catch (final CommandSyntaxException ex) {
--
src/test/java/com/mojang/brigadier/tree/LiteralCommandNodeTest.java-            fail();
src/test/java/com/mojang/brigadier/tree/LiteralCommandNodeTest.java:        } catch (final CommandSyntaxException ex) {

Pokechu22 avatar Nov 12 '21 00:11 Pokechu22

Closing and reopening to rerun checks.

peterix avatar Oct 26 '22 15:10 peterix