TvDb icon indicating copy to clipboard operation
TvDb copied to clipboard

Fixing HTTPS and exception on no results

Open jy-roda opened this issue 4 years ago • 1 comments

The TvDb api changed to https only. Requests to http endpoints fail. Using https fixes that. Unfortunately, the mirrors.xml file still gives http links. A quick workaround is to use the provided base url and disregard any mirrors (which are not provided in the mirrors.xml file anyway).

There was a bug where if no results were found for a certain request, the parsed xml response evaluated as false and triggered an exeption despite being valid. A stricter false check corrects this.

jy-roda avatar Aug 22 '20 15:08 jy-roda

Hi @jy-roda as I already said here https://github.com/Moinax/TvDb/issues/43 the TVDB api v1 is deprecated and I recommend using a new library that actually implements the api v2.

Moinax avatar Aug 27 '20 10:08 Moinax