Mohist icon indicating copy to clipboard operation
Mohist copied to clipboard

Published 20 hours ago • verified publisher icon MohistMC

[1.20.1] Issues with ConnectorExtras

Open GeekCornerGH opened this issue 11 months ago • 11 comments

Minecraft Version : 1.20.1

Mohist Version : 627

Operating System : Ubuntu 22.04 Jamy (through Docker image ghcr.io/pterodactyl/yolks:java_17)

Concerned mod / plugin : https://modrinth.com/mod/creativecore/version/2.11.25

Logs : With CreativeCore Without CreativeCore Steps to Reproduce :

  1. Add LittleTiles, and CreativeCore
  2. Boot up a MohistMC 1.20.1 with the build 627
  3. ???
  4. See the logs (no crash report will be produced)
  5. Remove CreativeCore
  6. Reboot the server
  7. ???
  8. A proper crash report will be generated, but server won't boot without CreativeCore
  9. Enjoy

Description of issue : The exacte same modlist will boot properly on regular Forge (47.2.20)

GeekCornerGH avatar Mar 21 '24 08:03 GeekCornerGH

The problem is caused by reach-entity-attributes mod

Mgazul avatar Mar 21 '24 09:03 Mgazul

The problem is caused by reach-entity-attributes mod

@Mgazul thanks for the fast reply. The issue seems produced by ConnectorExtras (which indeed uses reach-entity-attributes library). We use it because we use Architectury too. After removing the mod, it seems it will boot up properly. Is it planned to fix that behaviour?

GeekCornerGH avatar Mar 21 '24 10:03 GeekCornerGH

@TonimatasDEV you said in #2842 that you would fix any mixins issues with fabric, would you consider fixing this maybe?

GeekCornerGH avatar Mar 21 '24 14:03 GeekCornerGH

@TonimatasDEV you said in #2842 that you would fix any mixins issues with fabric, would you consider fixing this maybe?

I need to see it

TonimatasDEV avatar Mar 21 '24 14:03 TonimatasDEV

I need to see it

The stacktrace? Here is it

GeekCornerGH avatar Mar 21 '24 14:03 GeekCornerGH

@Shadow field f_143670_ was not located in the target class net.minecraft.server.network.ServerGamePacketListenerImpl$1 net.minecraft.server.network.ServerGamePacketListenerImpl$1 and f_143670_ do not exist in forge. This is probably something unique to fabric.

Mgazul avatar Mar 22 '24 06:03 Mgazul

@Shadow field f_143670_ was not located in the target class net.minecraft.server.network.ServerGamePacketListenerImpl$1 net.minecraft.server.network.ServerGamePacketListenerImpl$1 and f_143670_ do not exist in forge. This is probably something unique to fabric.

In normal forge works

TonimatasDEV avatar Mar 22 '24 14:03 TonimatasDEV

Indeed, it is an incompatibility with Mohist, hence why I opened the issue here. By the way, I'm available for testing, just tag me in a PR :)

GeekCornerGH avatar Mar 22 '24 16:03 GeekCornerGH

Still having this issue on the latest version. Not being able to use Connector Extras is a major inconvenience, is this planned to be fixed in the near future?

Magi1053 avatar Apr 17 '24 03:04 Magi1053

I am also running into this issue and it's a huge pain not being able to use Connector Extras. Is there any eta on if or when this will be fixed?

TrickShow avatar Apr 23 '24 03:04 TrickShow

At this point am I suppose to give up hope that this will ever be fixed.

Magi1053 avatar May 23 '24 01:05 Magi1053

Fixed

Mgazul avatar Jun 18 '24 16:06 Mgazul

Valkyrien skies breaks whatever was fixed here. I don't know what mohist is, I just found this thread and this seems relevant

https://pastebin.com/c5Qaic7K

Explode007 avatar Sep 04 '24 03:09 Explode007