Mohist icon indicating copy to clipboard operation
Mohist copied to clipboard

[1.16.5] Mohist - Framed Blocks - Tick Loop

Open AnCasper opened this issue 2 years ago • 11 comments

Minecraft Version : 1.16.5

Mohist Version : 963

Operating System : Windows

Concerned mod / plugin : Framed Blocks (all versions) - https://www.curseforge.com/minecraft/mc-mods/framedblocks

Logs : https://mclo.gs/BodThBR

Steps to Reproduce :

  1. Place a Framed Block (any)
  2. Place a block inside of it (any) crash
  3. Same works for the reversal, remove a block from the framed block (any) crash

Description of issue : All the information you need is listed above.

AnCasper avatar Apr 17 '22 20:04 AnCasper

Hello, thanks for opening this issue!

Before continuing, please understand that Mohist is a free and open source software, made by people in their free time. Know that we are not able to give any eta about when your issue will get answered or fixed.

Our team will first check if your issue isn't duplicated. If it's the case, we will close your issue, giving your the number of the other issue so that you can follow its progress. If you are able to do it, please check that your issue isn't duplicated, this would help us a lot.

Thank you for your patience, and have a nice day (or night)!

MohistBOT avatar Apr 17 '22 20:04 MohistBOT

there are two ways you can fix this issue disable the mod in question and then try to play or wait till its patched

zxoltari avatar Apr 18 '22 19:04 zxoltari

you would need to go to the mod authors GITHUB and make a issue with them even THO they may not support Mohist

Don't make an issue to the mod author is everything works fine with Forge. If it only doesn't work with Mohist, then it is up to us to solve the problem.

Shawiizz avatar Apr 18 '22 21:04 Shawiizz

At the time of writing this I can confirm that Framed Blocks now has partial support in Mohist build 971 for 1.16.5. (You can now place blocks inside of the Framed Block) without the server crashing.

@zxoltari

there are two ways you can fix this issue disable the mod in question and then try to play or wait till its patched

Yes, I am fully aware of both options including a third option which we are doing "informing people not to use Framed Blocks for the time being". Thank you :)

@Shawiizz Thank you for making headway on this issue, let the peoples know that what they do is super amazing and thank you! I will close this issue once everything with Framed Blocks is squared away.

AnCasper avatar Apr 26 '22 00:04 AnCasper

Mohsit Version - 974

New Crash Log - https://mclo.gs/kGKdMje

Extras (If Needed) - https://mclo.gs/SHzYujt

AnCasper avatar Apr 27 '22 17:04 AnCasper

The mod works with plain forge, it doesn't work with Mohist.

In the event that it is a Mohist + mod-compatibility issues, the Minecraft SMP community I'm part of is running ATM6 on Mohist, and we are getting the same crashes as well. so if someone starts looking into it, and cannot replicate the issue, we can share experience and any crash logs as well.

Also: this is a somewhat new behavior. we had framed blocks not crashing mohist for a soild few months, and something new in framedblocks/forge/mohist has caused the crashing behavior.

we have large player bases on our ATM6 server that were built with framedblocks and an update about a month-ish ago happened and we began crashing.

BrettMoan avatar May 02 '22 04:05 BrettMoan

Issue still persists on Mohist Version: 979

AnCasper avatar May 07 '22 20:05 AnCasper

Issue still persists on Mohist Version: 983

AnCasper avatar May 10 '22 15:05 AnCasper

is this issue resolved or no just wondering really wanna use mohist on my forge server

zxoltari avatar May 21 '22 19:05 zxoltari

@zxoltari No this issue has still not been resolved on Mohist or Magma Foundation. You can however use Sponge Forge. It works properly and so does the entire ATM6 pack. Unfortunately at the moment there are not a lot of Sponge ore plugins/mods to use yet. Good luck!

AnCasper avatar Jul 06 '22 20:07 AnCasper

Still not fixed as of Mohist version 1078

Recap: Framed Blocks crashes the server when you place a block inside the framed block, which is the whole point of the mod. Even if they patch it there will still be the problem of breaking the block as well. Magma has sorted the placement issue but not the breaking issue.

Sponge still works for the moment. Plugin support is slightly better than it was.

AnCasper avatar Sep 23 '22 21:09 AnCasper

Since I just stumbled upon this, I thought I might as well add my two cents as the author of FramedBlocks. What's happening here is that when a FramedBlocks TileEntity is deserialized from NBT, it's added to a list which is then iterated and cleared at the start of the next server tick. While it is guaranteed for a TE to be placed in the world and have the world object assigned to it within the same tick it was deserialized under Forge, this does not seem to be the case on Mohist, Magma and similar server implementations, which causes the crash seen in the crash reports linked above.

The system in question was added in FramedBlocks 2.14.0, released on March 4, 2022. It's a crude workaround for the "do something on first tick without your TE being a ticking TE" Forge hook being broken in 1.16 and not allowing world access (doing so would deadlock chunk loading).

XFactHD avatar Nov 07 '22 18:11 XFactHD