Mohammed Kaludi

Results 139 comments of Mohammed Kaludi

this feature is only supported on Design 1,2 and 3. But the control is visible on every design https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/9edaba61d9fd86110171f1249b3a9023b4942c1b#diff-d794f55e3ee0aead59adf8c61f67f9edR387

Remove this code as this is now taken care by ampforwp_get_setting() https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/05301aaa0532b9a81c9ce0b3af2e84c7effe0094#diff-5a452fac5c17477612b7a28b265b48aeR514

https://github.com/ampproject/amphtml/issues/24621#issuecomment-848715411 This feature is still under development as of today: ![image](https://user-images.githubusercontent.com/16618009/122339467-c261d900-cf5e-11eb-88b4-22d4874bba5b.png)

Ready to merge. But need to update the labeling.

escaping missing in nonce https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/0376fffb128b08c2b35cce0b5ac7c03acacbbbe2#diff-4c7e8aaf3d2ea6555ce6cdd4ecae8e69R1207