Mohammed Kaludi comments

Results 139 comments of


                                            Mohammed Kaludi

Need to improve "Optimize For Viewability documents" option.

Viewability option should be Ad-specific

Need to improve "Optimize For Viewability documents" option.

Need some improvements in the code after discussing with Ahmed,

Need to have the design menus in the design section

https://take.ms/eAbVF

Need to have the design menus in the design section

Will push this feature after the UI Ticket is resolved

Need to create an option under dev mode to show amp pages only for logged in users or not?

ready to merge.

amp menu (header) submenu is not getting visible when clicking on the parent menu

use existing dom utils function instead of creating a new one. https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/b4694d5f8e42ec11fe9dd5a18e8e3dc07e1b9ae2#diff-6aa5512f7dd8d5ce60fc97b0f340912cR7248

amp menu (header) submenu is not getting visible when clicking on the parent menu

code still need improvement also i think savehtml can be changed to domutils inner functions https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/b4694d5f8e42ec11fe9dd5a18e8e3dc07e1b9ae2#diff-6aa5512f7dd8d5ce60fc97b0f340912cR7295

amp menu (header) submenu is not getting visible when clicking on the parent menu

Ready for merge

Need to do design improvements in AMP Option panel

Ready to merge.

Need increase the row module height in the AMP page builder section

Height not applying for fixed Grid type. https://take.ms/lVCMm