Mohammed Kaludi
Mohammed Kaludi
Many issues in this. Get back to me before fixing the issue..
Ready to merge.
escaping missing on multiple places/
here `get_query_var('tag')` needs escaping. https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/52e163d637c7fd0b1e22f44c1f46120b5a8e04e4#diff-6aa5512f7dd8d5ce60fc97b0f340912cR7346
This ticket is related to code improvements, this is not a bug also there are few improvements. - [x] can we use singular function like `amp_breadcrumb` or `amp_breadcrumb_output` or create...
Ready to merge.
wrap it into a condition, https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/451d171863212b8c13aee3c3002864984a379c4a#diff-ed45a2516e7139734f28a770b4e7afd7R455 otherwise it can break other amp-image tags.
Ready to merge
Lightbox true needs to be in the condition? here https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/df1e21d9306019e5bfe2260510e4a836fab87387#diff-e7f6ca8ce090f4ff7573a4eec8ccf52dR174 to here: https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/df1e21d9306019e5bfe2260510e4a836fab87387#diff-e7f6ca8ce090f4ff7573a4eec8ccf52dR188
Ready to merge.