Calf icon indicating copy to clipboard operation
Calf copied to clipboard

Separate Web-View from UI Package

Open Shahriyar13 opened this issue 1 year ago • 1 comments

Please review it, I am not sure about adding CocoaPods/Regular Framework dependency is because of WebView or not, If it's true, the documents should be change too.

Because of JavaFX usage in WebView module, and adding JavaFX and coroutines only because of WebView, I separated WebView to another package:

api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")

com.sun.javafx.application.PlatformImpl startup
WARNING: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @82702de'
Exception in thread "JavaFX Application Thread @coroutine#1" java.lang.IllegalArgumentException: Not on Main thread, current thread is: Thread[#24,JavaFX Application Thread @coroutine#1,5,system]

Shahriyar13 avatar Dec 07 '23 18:12 Shahriyar13

If you agree for next release:

Breaking Changes:

WebView removed from UI:

// For Adaptive WebView components
api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")

Shahriyar13 avatar Dec 07 '23 19:12 Shahriyar13

Thanks for your contribution. Sorry for taking too much to accept this.

MohamedRejeb avatar Jun 20 '24 20:06 MohamedRejeb