C# colors don't match

[Nekketsu]

This image is from VSCode:

This image is from Mofiqul/vscode.nvim:

As you can see, most of the pink colors in the plugin are blue in VSCode. Is it posible to fix it?

[redfoggg]

I think it is possible to fix this with not that much of an effort, if I get some free time I will try to do it.

[Nekketsu]

Any news about it? Could you please give me a hint or how to solve it by overriding the group_overrides? I tried something like this, but it seems that is not working:

    group_overrides = {
        -- this supports the same val table as vim.api.nvim_set_hl
        -- use colors from this colorscheme by requiring vscode.colors!
        -- Cursor = { fg=c.vscDarkBlue, bg=c.vscLightGreen, bold=true },
        ["@keyword"] = { fg = c.vscBlue, bg = c.vscNone },
        ["@include"] = { fg = c.vscBlue, bg = c.vscNone },
        ["@keyword.return"] = { fg = c.vscPink, bg = c.vscNone }
    }

[Nekketsu]

It is working. I had to change the order in which I load the colorscheme and the plugin config. First set colorscheme to vscode, and then load plugin configuration and the overrides:

-- require('config.vscode')
require('config.colorscheme')
require('config.vscode')

[bryankenote]

This seems to have improved recently. Maybe https://github.com/Mofiqul/vscode.nvim/pull/181? Are there any differences that still exist that can be documented here?

[johannesrld]

I can take a look later to see what can be improved, there are still some differences between the original vscode theme and this theme that I haven't fixed, but some of them require custom scheme highlight queries (for example C# and Javascripts => for arrow functions is highlighted as a keyword in vscode but if you want that in neovim you'd have to make custom scheme queries)

[johannesrld]

Also vscode itself is rather inconsistent with its highlighting, in the above example the IrcClient constructor function in C# is highlighted with the same green that types and classes are highlighted with, however in typescript and javascript the constructor() function is highlighted with the same blue that non-control flow keywords are highlighted with, currently vscode.nvim (intentionally) highlights constructors with blue instead of green. There isn't really any way to solve this without introducing a bunch of extra definitions for different languages, which I don't think is a good use of anyones time (and honestly I value consistency over being a 100% faithful recreation)

There are also places where I think VSCodes original highlighting is just straight up stupid like with CSS selectors.