token-mold icon indicating copy to clipboard operation
token-mold copied to clipboard

Published 20 hours ago • verified publisher icon Moerill

Update to V11 style data

Open BeardedGnome opened this issue 10 months ago • 2 comments

ESLint/Prettier made a lot of extraneous changes. The important ones are:

  • Remove V9 and V10 support
  • Change actorAttributes to use new V11 system data model as described here: https://foundryvtt.com/article/active-effects/

fixes #202 fixes #197 fixes #186

BeardedGnome avatar Apr 13 '24 01:04 BeardedGnome

@Moerill and @Geekswordsman ,

I apologize for the mess ESLint/Prettier made of your code. Hopefully the v11 fix I made in _actorAttributes() is clear.

BeardedGnome avatar Apr 13 '24 01:04 BeardedGnome

@paladintodd and @JasonSunday ,

Can you see if this change fixes Savage Worlds for you?

BeardedGnome avatar Apr 13 '24 01:04 BeardedGnome

It is still the same. token-mold

JasonSunday avatar May 01 '24 00:05 JasonSunday

Strange. It's working for me. Are you using the version from this PR or using Moerill's release?

image

BeardedGnome avatar May 03 '24 04:05 BeardedGnome

Moerill's release.

What is the manifest link to your fork?

JasonSunday avatar May 10 '24 17:05 JasonSunday

I've never tried installing it from GithHub, but you can try this URL: https://raw.githubusercontent.com/BeardedGnome/token-mold/master/module.json

BeardedGnome avatar May 11 '24 00:05 BeardedGnome

Hello, @BeardedGnome, I tried using your module from the manifest provided, but there seems to be an error. In your manifest.json you include a release that does not exist.

"download": "https://github.com/Moerill/token-mold/releases/download/v2.21.0/v2.21.0.zip",

You should create a release from a tag in your fork and replace this inclusion with your own something like.

"download": "https://github.com/BeardedGnome/token-mold/releases/download/v2.21.0/v2.21.0.zip",

Visovsiouk avatar May 17 '24 12:05 Visovsiouk

@Visovsiouk @JasonSunday

Figured out how to publish a release. Unfortunately, it broke this PR. I'll have to figure out how to fix that now.

Edit: Looks like I'll have to fork a new branch and create a new PR.

BeardedGnome avatar May 22 '24 06:05 BeardedGnome

@Visovsiouk @JasonSunday

Does it work for you? https://raw.githubusercontent.com/BeardedGnome/token-mold/master/module.json

BeardedGnome avatar Jun 21 '24 01:06 BeardedGnome

I had to publish a breaking version for Foundry v12:

Foundry v11: https://raw.githubusercontent.com/BeardedGnome/token-mold/v2.21.0/module.json Foundry v12: https://raw.githubusercontent.com/BeardedGnome/token-mold/v2.22.1/module.json

BeardedGnome avatar Jul 08 '24 05:07 BeardedGnome