budgeting icon indicating copy to clipboard operation
budgeting copied to clipboard

Published 20 hours ago • verified publisher icon ModusCreateOrg

React hot loader v4

Open Suraj-Chandola opened this issue 7 years ago • 5 comments

resolve #208

Suraj-Chandola avatar Nov 20 '18 19:11 Suraj-Chandola

Coverage Status

Coverage remained the same at 77.524% when pulling 6c1ef9f82f0642abdf79adef723992213b747ceb on Suraj-Chandola:react-hot-loader-v4 into 95e67da63ffb5e203a6a21edb0dec59c364c6893 on ModusCreateOrg:master.

coveralls avatar Nov 20 '18 19:11 coveralls

Thank you so much for working on this @Suraj-Chandola

I checked it out, but I'm not sure I see RHL working well. Changes keep on reloading the browser

animation

Could you take a look please? Also, it's ok if you want to upgrade with RHL 4.5.1+

grgur avatar Nov 21 '18 09:11 grgur

Code Climate has analyzed commit 6c1ef9f8 and detected 0 issues on this pull request.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Nov 22 '18 12:11 qlty-cloud-legacy[bot]

@grgur Fixed and updated to 4.5.1

Suraj-Chandola avatar Nov 22 '18 12:11 Suraj-Chandola

Thanks for updating! I still see a refresh when changing code, no matter where. Can you replicate that? I tried adding random text to App/index.js and Budget/index.js and it reloaded on both occasions

grgur avatar Nov 26 '18 09:11 grgur