Elasticsearch

[coatesjonathan]

Can you add Elasticsearch because Magento 2.3.1 now has ElasticSearch 6 enabled by default.

https://devdocs.magento.com/guides/v2.3/config-guide/elasticsearch/es-config-nginx.html

[danielozano]

Hi @coatesjonathan we will add it as optional service when we've some time, if you already have it working please feel free to PR us!

[ihor-sviziev]

Hi @coatesjonathan we will add it as optional service when we've some time, if you already have it working please feel free to PR us!

Hi @danielozano,

Created PRs: https://github.com/ModestCoders/dockerfiles/pull/11 https://github.com/ModestCoders/magento2-dockergento/pull/56

Note: during installing it I got one issue: vm.max_map_count was too low in Ubuntu. Fixed by following instruction https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html#docker-cli-run-prod-mode

This is just 1st version.

Questions that not solved yet:

1. Should ES be optional?
2. Should we have some docs for configuring ElasticSearch?
3. How to add ElasticSearch to existing installations?

[danielozano]

Hi @ihor-sviziev, thats true! It's been a long time without updating this issue because of that. For now lets have it included and if someone doesn't want it, just remove it from the setup.

I had a prototype of a "service injector". It was just another command that takes 1 template: the service definition in YAML, and replace some variables. But this variable substitution was hard, and injecting the result into the original docker-compose.yml was overcomplicated.

I would like to have something like that to be as flexible as possible, but maybe it's too much work for non-profit at all.

So let me know it you have some idea, if not maybe just include all the necessary services and start creating some wiki content should be fine!

Thanks again! (I will merge the PRs but im not going to close the issue to keep this conversation)

[ihor-sviziev]

Hi @danielozano,

Adding "service injector" is quite big task and I think we're not going to have too many things. I think following only could be added: Elasticsearch, Varnish, Redis, RabbitMQ.

I think we could update setup CLI that will ask if you would like to include Elasticsearch (default value - no) + writing selected option to config file in order to have an ability re-generate configs again.

Also updating docs - good idea.

Another point - Magento currently developing https://github.com/magento/magento-cloud-docker, but it looks too complicated as for me. Maybe we can re-use their work somehow?