ModernFlyouts icon indicating copy to clipboard operation
ModernFlyouts copied to clipboard

Adding support for MediaSession.setPositionState() & Seekto event

Open ramtinarefkia opened this issue 3 years ago • 4 comments

Description of the new feature / enhancement

I'm aware of this page which clearly says chromium based browsers doesn't support GSMTC timeline, thus the ModernFlyouts seek bar feature cannot be used with them. but there is a MediaSession.setPositionState() & seekto over MediaSession.setActionHandler() which can perfectly provide information needed by seek bar & seek to a position specified by seek bar. I've tested those already & (as expected) not working. I'm requesting to add support for this over browsers.

Scenario when this would be used?

playing audio through a browser.

Additional context

No response

ramtinarefkia avatar Jan 27 '22 18:01 ramtinarefkia

Hi @ramtinarefkia , I wasn't aware of that. This has been a continuing problem, to the point where we have even been deliberating whether to make a browser extension to pass the info to us.

We are quite busy with 0.11 at the moment, would you be able to create a pr to add this?

Samuel12321 avatar Jan 27 '22 21:01 Samuel12321

Hello @Samuel12321, I'm afraid I'm not an experienced user in GitHub & don't know how to create a pull request for this. I tried using "New pull request" button but not sure which branches should be chosen to compare. could you walk me through it?

ramtinarefkia avatar Jan 27 '22 22:01 ramtinarefkia

Hi @ramtinarefkia, no problem. The branches are a bit of a mess at the moment, will clean them up for the 0.11 release. The branch we are currently working on is 0.11-final. Click create pull request, then compare your branch (with your changes) to head branch (0.11-final). Just let me know if you need any help.

Samuel12321 avatar Jan 28 '22 00:01 Samuel12321

many thanks @Samuel12321! So this all means I should create a branch, change the code, compare mine with 0.11-final & create a pull request? Well, C# is not my area I'm afraid. is there other ways to help about this request of mine?

ramtinarefkia avatar Jan 28 '22 00:01 ramtinarefkia