ModernFlyouts icon indicating copy to clipboard operation
ModernFlyouts copied to clipboard

Add Support Twinkle Tray Brightness Slider

Open pc-v2 opened this issue 3 years ago • 9 comments

Description of the new feature / enhancement

Supporting Twinkle Tray to show brightness slider in ModernFlyouts

Scenario when this would be used?

Adjusting brightness with twinkletray with hotkeys still show old windows 8 brightness slider, by adding this, the experience using both program become great

Additional context

image image image

pc-v2 avatar Jan 15 '22 05:01 pc-v2

We aim to completely replace the twinkle tray functionality in 0.11.

Is the image above a mockup?

Samuel12321 avatar Jan 15 '22 06:01 Samuel12321

We aim to completely replace the twinkle tray functionality in 0.11.

Is the image above a mockup?

The image above may be from https://github.com/xanderfrangos/twinkle-tray

iosyyy avatar Jan 15 '22 07:01 iosyyy

We aim to completely replace the twinkle tray functionality in 0.11.

Is the image above a mockup?

yes the last one, it's a mockup

pc-v2 avatar Jan 15 '22 22:01 pc-v2

Developer of Twinkle Tray here. To clarify, all UI displayed by Twinkle Tray is custom made (including the "Windows 8 style" brightness hotkey slider). One of the Modern Flyouts devs had commented on this previously. There's nothing Modern Flyouts can do to modify/use Twinkly Tray's UI, or vice versa.

If the Modern Flyouts devs are planning to implement their own WMI/DDC brightness controls, then Twinkle Tray wouldn't have anything to do with it. A collaboration isn't impossible, but it doesn't make a lot of sense to do. I don't think they'd need my help with that.

xanderfrangos avatar Jan 15 '22 23:01 xanderfrangos

Hi @xanderfrangos, Yes we are planning to implement our own WMI/DDC brightness controls, hopefully in the 0.11 release. We would welcome a collaboration, as we are always looking for help.

Samuel12321 avatar Jan 16 '22 00:01 Samuel12321

@Samuel12321 I'd be happy to help, though I'm not sure what I can contribute. Twinkle Tray is primarily a UI built on other people's libraries. Even though I've helped out with the C++ WMI/DDC code used in Twinkle Tray, I honestly don't understand how it works at a low level, nor how to translate it to C#. I do understand it all at a high level, along with the quirks of WMI and DDC/CI.

xanderfrangos avatar Jan 18 '22 17:01 xanderfrangos

@xanderfrangos do you have a discord account so we can discuss this further?

Samuel12321 avatar Jan 26 '22 19:01 Samuel12321

@Samuel12321 Yeah, Xander#5415.

xanderfrangos avatar Jan 27 '22 19:01 xanderfrangos

Couldn't ModernFlyouts expose an API for third party applications to access and display flyouts? maybe just support a basic level of custom icon, min max and custom numerical value. or if that sounds too much, just a custom icon, enforced 0-100 default min max and numerical value.

thewan056 avatar Jun 12 '22 18:06 thewan056