ModernFlyouts icon indicating copy to clipboard operation
ModernFlyouts copied to clipboard

Feature Request: Make rounded corners optional

Open neubland opened this issue 4 years ago • 8 comments

I use ModernFlyouts in Win10. I would like to be able to choose between having rounded corners or regular corners (like the standard Flyout has).

neubland avatar Oct 01 '20 12:10 neubland

Could be a simple implementation.

Please answer some questions:

  • In what places do you want sharp corners?

  • Do you only want the flyout to be rectangular or other controls (such buttons, slider & etc) too?

  • Would you like a toggle switch or a slider to control the CornerRadius?

ShankarBUS avatar Oct 01 '20 13:10 ShankarBUS

I would want sharp corners in the edges of the flyout. The controls I haven't given much thought, I think they are not as important. I would prefer a toggle switch. I don't want to fine tune (or have the feeling that I need to fine tune), just choose between two options.

Thanks for the response!

neubland avatar Oct 01 '20 13:10 neubland

Could be a simple implementation.

Please answer some questions:

  • In what places do you want sharp corners?
  • Do you only want the flyout to be rectangular or other controls (such buttons, slider & etc) too?
  • Would you like a toggle switch or a slider to control the CornerRadius?

On my side I would like the corner radius to fit the system design. Currently Windows 10 is mainly using sharp corners but later it will hopefully change to a slightly rounder corner (but not as round as the one in MordenFlyouts). A slide or several options would be great to have.

AkazaRenn avatar Nov 23 '20 16:11 AkazaRenn

The corner radius was chosen from Windows 10X global media controls' layout.

Windows 10X uses 8px corner radius for the media control. I just copied their layout. WinUI uses 4px for popups and flyouts and 2px for other controls.

I didn't make my own decisions. I just copy pasted the layout 😅.

ShankarBUS avatar Nov 23 '20 17:11 ShankarBUS

The corner radius was chosen from Windows 10X global media controls' layout.

Windows 10X uses 8px corner radius for the media control. I just copied their layout. WinUI uses 4px for popups and flyouts and 2px for other controls.

I didn't make my own decisions. I just copy pasted the layout 😅.

Sorry I didn't mean it is wrong, but Microsoft is doing shits all the time. Two options might not fit three system designs (current Windows 10, probably future Windows 10, Windows 10 X), a slide would help a lot here.

AkazaRenn avatar Nov 23 '20 17:11 AkazaRenn

Ok great!

ShankarBUS avatar Nov 23 '20 17:11 ShankarBUS

I definitely would like all of them to be configurable, especially that even when I do move to 11 in few years I'll get rid of rounded corners for sure so following default system design wouldn't work for me

zakius avatar Dec 06 '21 08:12 zakius

code example https://github.com/BigFloppa404/To-Do_App/blob/ea9941575ab726e24854c3a5c48f179957c4ad27/To-Do/Settings.xaml.cs#L87

Samuel12321 avatar May 07 '22 06:05 Samuel12321