ModernFlyouts icon indicating copy to clipboard operation
ModernFlyouts copied to clipboard

Feature Request: Ability to control volume per-app

Open Samuel12321 opened this issue 4 years ago • 17 comments

One of the most requested changes from store feedback is to add individual app volume control to ModernFlyouts.

Samuel12321 avatar Nov 02 '20 03:11 Samuel12321

Woah! @Samuel12321, are you kidding me?

You do know it's very hard to do, don't you?

It will require intense work!

ShankarBUS avatar Nov 02 '20 03:11 ShankarBUS

hence very low priority and post v1.0 labels.

A lot of the work has already been done by the ear trumpet team. But it is something to consider in the future when the app is out of preview.

Samuel12321 avatar Nov 02 '20 03:11 Samuel12321

Is this really required? I mean, it's just a flyout, right?

prakharb5 avatar Nov 02 '20 10:11 prakharb5

If it was just a flyout, I wouldn't have added new features to the GSMTC module.

LoL

@WindowsFanBoi, does this proposal somehow overlap with yours in #103?

ShankarBUS avatar Nov 02 '20 10:11 ShankarBUS

@ShankarBUS Aye Aye, captain!

Looks like it is overlapping.

prakharb5 avatar Nov 02 '20 11:11 prakharb5

If the EarTrumpet devs look at this and #103, they'll kick our asses lol 😂.

Our plan should not be to replace EarTrumpet. We shouldn't disgrace their app this way. Let's give it the respect it deserves 😶.

@Samuel12321, Could you edit the title to say "Ability to control volume per-app"?

And in the detail we can say similar to EarTrumpet.

But we are gonna steal code from them anyways (if we were to implement this feature) 😂.

ShankarBUS avatar Nov 02 '20 11:11 ShankarBUS

Eartrumpet is anyways open source. No trademark there. Who will stop us?

prakharb5 avatar Nov 02 '20 11:11 prakharb5

Perhaps a collaboration to integrate ear trumpet into modern flyout and vice versa? Not a developer, so apologies if that isn't possible and I am out of scope.

Amit-Shan avatar Nov 03 '20 02:11 Amit-Shan

EarTrumpet is stable, so they won't want to have any new breaking change. Even I asked them if I could add the media controls to their app as I have some experience on that.

https://github.com/File-New-Project/EarTrumpet/issues/475

But they rejected my offer sedly 😢.

So, the only way is us integrating (stealing) features from EarTrumpet.

ShankarBUS avatar Nov 03 '20 03:11 ShankarBUS

technically not stealing as Ear trumpet uses a MIT licence so we can use any of their code. Ear trumpet seems to be not actively developed at the moment, last update was in February.

Samuel12321 avatar Nov 03 '20 03:11 Samuel12321

Yeah, it seems to have fallen to a lull moment, for now. We can "borrow" code freely. 😁😁

prakharb5 avatar Nov 03 '20 04:11 prakharb5

Ha ha. Fair enough. Good luck!

Amit-Shan avatar Nov 03 '20 05:11 Amit-Shan

EarTrumpet dev here: We're more than happy to replace our flyout, but we have a lot of constraints (e.g. needs to be wpf, downlevel support, acrylic, have all the right accessibility, controls, high dpi, animations, etc.). Does ModernFlyouts support that?

riverar avatar Dec 12 '20 01:12 riverar

Hi @riverar , ModernFlyouts is wpf, high dpi, has animations, and we are working on acrylic (@ShankarBUS has managed to find a way to add acrylic without the dragging lag #68).

We are open to adding/ accepting the addition of anything you felt nessesary.

@riverar we would be more than happy to add you as a collaborator if you wanted.

@ShankarBUS any thoughts/ anything you want to add.

Samuel12321 avatar Dec 12 '20 04:12 Samuel12321

I'm just amazed! I'm too happy that they agreed to collaborate with us ❤️.

But downlevel support could be cut up to Windows 10 1809+ due to MSIX packaging.

Accessibility support needs further investigation. We need provide full accessibility support at least to the tray flyout.

Well, my acrylic method would restrict the minimum supported OS to Windows 10 1903 (due to Visual Layer dependency and reg free activation requirement).

Most of our existing user base are on Windows 10 1903+. So, I don't think this will block our path.

ShankarBUS avatar Dec 12 '20 05:12 ShankarBUS

@FireCubeStudios came up with an interesting concept for this, which could be helpful for future flyout designs. For now the plan is to use this in a new tray flyout. image

Samuel12321 avatar Oct 14 '21 21:10 Samuel12321

Checkout Volumey it even has an option for custom hotkeys for each application well leaving that aside, looking forward for the update love to have this https://github.com/ModernFlyouts-Community/ModernFlyouts/issues/164#issuecomment-943767651 volume flyout view

rajeshbhavikatti avatar Mar 31 '22 21:03 rajeshbhavikatti