factorMerger icon indicating copy to clipboard operation
factorMerger copied to clipboard

is the whole knitr needed for kable() function?

Open MarcinKosinski opened this issue 7 years ago • 1 comments

without the kable used here

https://github.com/MI2DataLab/factorMerger/blob/c8c3c486b994dcad0499f0de12f4ad7cc4c9d944/R/factorMergerClasses.R#L212-L228

knitr could be moved from Imports to Suggests, hence final user doesn't have to rely on the knitr version to use the factorMerger.

What about copying the knitr::kable function to the factorMerger code? Or maybe what about requiring from the final user to have this package installed like stringi are just required but not imported for rvest ?

https://github.com/hadley/rvest/blob/9a51a5d3be1b8247250da4c3732ebfcf70fd2249/R/encoding.R#L31-L41

encoding in rvest ins't the crucial function that's why it dependencies are not in the imports of the package. I have no idea if here user can live without the print method for factorMerger object?

This is just a small start of the dependencies discussion @durszlaczek

MarcinKosinski avatar Jan 03 '18 18:01 MarcinKosinski

or just copy the part of the kable function responsible for the default markdown output.

MarcinKosinski avatar Jan 03 '18 21:01 MarcinKosinski