Modality-toolkit icon indicating copy to clipboard operation
Modality-toolkit copied to clipboard

groupType expansion needs full testing with devices.

Open adcxyz opened this issue 7 years ago • 3 comments

ATM groupTypes like noteOnOff, noteOnOffTouch expand properly into MKtlElements, but not yet into proper responders and midi lookup dict entries within MIDI devices. -> Do extensive tests of all types and their expansion.

adcxyz avatar Jul 06 '17 20:07 adcxyz

expansion works now with 97e01f3, gui style does not propagate down correctly yet. still needs full test suite.

adcxyz avatar Jul 07 '17 17:07 adcxyz

GUI looks like a new issue to me, no?

LFSaw avatar Jul 12 '17 06:07 LFSaw

yes, could also be a new issue - the problem is more general / conceptual, namely what the clearest form of description is and how to write passing things down into the elements so they work correctly. My current idea is loosely:

// element desc of an auto-expanding group:
(
    // things that describe the group, such as name:
    key: \dings, 
// this determines which set of what elements are made:
    groupType: \noteOnOffCtl, 
// this expands into list that goes into  elements one by one:
    midiNum: [24, 24, 48], 
    // everything the elements share
    shared: (
        style: (row: 0, column: 1), 
    ), 
    // maybe allow adding extra elements that go into the group
    // not really sure this is a good idea 
    elements: [ 
         (elementType: \led, ioType: \out), 
    ]
)
)

This should also include elements that have separate midiNums for output (e.g. setting moving faders or led indicators), not sure how best to do that.

opinions please :-)

adcxyz avatar Jul 13 '17 08:07 adcxyz