ACTR importer condition typo?

Open kmantel opened this issue 2 years ago • 1 comments

https://github.com/ModECI/MDF/blob/2e9cd9c41aed8486b93ba7c0ac06258a0bfb20a1/src/modeci_mdf/interfaces/actr/importer.py#L203-L215

Should

https://github.com/ModECI/MDF/blob/2e9cd9c41aed8486b93ba7c0ac06258a0bfb20a1/src/modeci_mdf/interfaces/actr/importer.py#L213

 Condition(type="EveryNCalls", dependencies=pm_node.id, n=1),

instead? There's an edge from pm_node (not dm_node) to pattern_node.

Feb 01 '24 23:02 kmantel

Hey, I'm Dawit. Glad to be here.

Thanks to this project, I've found an exciting opportunity to work on AI/ML-related tasks. With my prior experience in AI/ML internships and UI development, I'm eager to contribute my skills to this project.

I am getting my hands dirty on Jupyter Notebook by experimenting with MDF models. I have been tinkering with Streamlit as well to create some user interfaces. It's been a fun experience, especially considering my previous experience with Streamlit.

I would love to start my contribution by fixing the issue mentioned above. ✌

Mar 06 '24 19:03 dawit-andargachew