MDF icon indicating copy to clipboard operation
MDF copied to clipboard
verified publisher icon ModECI

Function 'function' field is dict instead of str

Open kmantel opened this issue 4 years ago • 4 comments

Since d1f49379651d80613e2b2181a0b6e91171a016a2, the 'function' field of Function is a dict (changed from str) expected to contain args and their values. ex: https://github.com/ModECI/MDF/blob/48e2b2e22188cb83bbe36e66f9692f411ae70f02/examples/MDF/translation/Translated_ABCD.json#L122-L130

Why use this dictionary format instead of handling the function arguments in the 'args' field as with evaluable expressions? This change seems to add extra complexity

kmantel avatar Jan 11 '22 04:01 kmantel

hey @kmantel, I would like to work on this issue. Could you please assign this task to me .

harshithakolipaka avatar Mar 05 '23 07:03 harshithakolipaka

@kmantel I would like to work on this issue, would you please assign this issue to me.

WhiteWolf47 avatar Mar 06 '23 20:03 WhiteWolf47

Hi, will check back and assign one of you soon

kmantel avatar Mar 07 '23 20:03 kmantel

This issue is more to track a proposed design change to the MDF formal specification for parameters and functions rather than a bug fix I'm afraid. It requires examination of the merits of the change by the MDF developers rather than something that just needs a quick change in the code, so is probably something more for the actual internship rather than the contribution phase.

pgleeson avatar Mar 14 '23 15:03 pgleeson