MockBukkit icon indicating copy to clipboard operation
MockBukkit copied to clipboard

Disable Compiler Warnings

Open thelooter opened this issue 1 year ago • 4 comments

Description

Disables the Gradle Compiler Warnings

Checklist

The following items should be checked before the pull request can be merged.

  • [x] Unit tests added.
  • [x] Code follows existing code format.

Info on creating a pull request

  • Make sure that unit tests are added which test the relevant changes.
  • Make sure that the changes follow the existing code format.

For maintainer

When a PR is approved, the maintainer should label this PR with release/*.

  • If the PR fixes a bug in MockBukkit, update the patch version. (if the current version is 0.4.1, the new version should be 0.4.2)
  • If the PR adds a new feature to MockBukkit, update minor version. (if the current version is 0.4.1, the new version should be 0.5.0)

Note that a PR that fixes an UnimplementedOperationException should be considered a new version and not a bugfix.

thelooter avatar Oct 08 '22 21:10 thelooter

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Oct 08 '22 21:10 sonarcloud[bot]

Wouldn't it be better to fix the warnings rather than disable them?

Insprill avatar Oct 09 '22 02:10 Insprill

It's mainly Warnings that Methods are Deprecated / Deprecated for Removal. But since we need to have all Methods present, there is no way to fix them.

thelooter avatar Oct 10 '22 10:10 thelooter

I'd rather manually suppress them in code. Disabling all compiler warning is a bad idea.

Insprill avatar Oct 10 '22 11:10 Insprill