MockBukkit icon indicating copy to clipboard operation
MockBukkit copied to clipboard

Implement passenger/vehicle handling when spawning entities

Open Insprill opened this issue 2 years ago • 1 comments

Description

Uncomments the passenger/vehicle handling code when spawning entities. To properly support this, EntityMock#getIndirectPassengers has been added.

Another minor change that is a little small for it's own PR is passing the proper SpawnReason when dropping items.

Checklist

The following items should be checked before the pull request can be merged.

  • [x] Unit tests added.
  • [x] Code follows existing code format.

Info on creating a pull request

  • Make sure that unit tests are added which test the relevant changes.
  • Make sure that the changes follow the existing code format.

For maintainer

When a PR is approved, the maintainer should label this PR with release/*.

  • If the PR fixes a bug in MockBukkit, update the patch version. (if the current version is 0.4.1, the new version should be 0.4.2)
  • If the PR adds a new feature to MockBukkit, update minor version. (if the current version is 0.4.1, the new version should be 0.5.0)

Note that a PR that fixes an UnimplementedOperationException should be considered a new version and not a bugfix.

Insprill avatar Oct 02 '22 12:10 Insprill

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 07 '22 02:11 sonarqubecloud[bot]

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@Insprill can this be merged

thelooter avatar Apr 22 '23 11:04 thelooter

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 22 '23 18:04 sonarqubecloud[bot]