MockBukkit icon indicating copy to clipboard operation
MockBukkit copied to clipboard

Properly implement first/last played methods

Open Insprill opened this issue 2 years ago • 1 comments

Description

Properly implements the following methods in OfflinePlayerMock and PlayerMock:

  • #getFirstPlayed()
  • #getLastSeen()
  • #getLastLogin()
  • #getLastPlayed()
  • #hasPlayedBefore()

Just waiting on tests to be written.

Checklist

The following items should be checked before the pull request can be merged.

  • [ ] Unit tests added.
  • [x] Code follows existing code format.

Info on creating a pull request

  • Make sure that unit tests are added which test the relevant changes.
  • Make sure that the changes follow the existing code format.

For maintainer

When a PR is approved, the maintainer should label this PR with release/*.

  • If the PR fixes a bug in MockBukkit, update the patch version. (if the current version is 0.4.1, the new version should be 0.4.2)
  • If the PR adds a new feature to MockBukkit, update minor version. (if the current version is 0.4.1, the new version should be 0.5.0)

Note that a PR that fixes an UnimplementedOperationException should be considered a new version and not a bugfix.

Insprill avatar Sep 11 '22 22:09 Insprill

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Oct 12 '22 13:10 sonarqubecloud[bot]