gtfs-validator icon indicating copy to clipboard operation
gtfs-validator copied to clipboard

feat: display ERRORS first on validator documentation

Open cka-y opened this issue 1 year ago • 6 comments

Summary: Closes #1605

Expected behavior: ERROR notices are displayed first, followed by WARNING and then INFO in both the documentation and validation report.

Screenshot 2024-02-09 at 2 33 56 PM

Screenshot 2024-02-27 at 1 34 49 PM

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Run the unit tests with gradle test to make sure you didn't break anything
  • [x] Add or update any needed documentation to the repo
  • [x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • [x] Linked all relevant issues
  • [x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

cka-y avatar Feb 09 '24 19:02 cka-y

@cka-y It looks like this original order is also affecting the actual HTML report (it's warning, info, error right now). I assume this would be a different issue - is that correct?

emmambd avatar Feb 20 '24 20:02 emmambd

@cka-y It looks like this original order is also affecting the actual HTML report (it's warning, info, error right now). I assume this would be a different issue - is that correct?

I included it as part of this PR

cka-y avatar Feb 27 '24 18:02 cka-y

✅ Rule acceptance tests passed. New Errors: 0 out of 1502 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1502 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1502 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 0 out of 1502 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 3 out of 1505 sources (~0 %) are corrupted. Corrupted sources: ae-abu-dhabi-emirate-department-of-municipalities-and-transport-gtfs-1329 at-wien-wiener-lokalbahnen-wlb-gtfs-648 ca-quebec-societe-des-transports-de-rimouski-gtfs-760 Commit: 7dc620ff42b57d8de83de628acff39d3bcee3054 Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.

github-actions[bot] avatar Feb 27 '24 19:02 github-actions[bot]

✅ Rule acceptance tests passed. New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1520 sources (~0 %) are corrupted. Commit: a1a0465d8b4fad3ba2c43842027fc386cdd3e4fc Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.

github-actions[bot] avatar Mar 06 '24 21:03 github-actions[bot]

✅ Rule acceptance tests passed. New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1520 sources (~0 %) are corrupted. Commit: 4695ba48a90576834a3f40242adc60582745bf60 Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.

github-actions[bot] avatar Mar 08 '24 21:03 github-actions[bot]

✅ Rule acceptance tests passed. New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1520 sources (~0 %) are corrupted. Commit: 9b32d42119660ccac181e68e7cbc61eaf97790ac Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.

github-actions[bot] avatar Mar 08 '24 22:03 github-actions[bot]

✅ Rule acceptance tests passed. New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. 0 out of 1520 sources (~0 %) are corrupted. Commit: ac1f878d80b2b213772681d871860834161b47cd Download the full acceptance test report here (report will disappear after 90 days). ✅ Rule acceptance tests passed.

github-actions[bot] avatar Mar 11 '24 19:03 github-actions[bot]