gtfs-validator
gtfs-validator copied to clipboard
MobilityData
Add a rule for missing stop name
What problem in GTFS datasets does this new rule address? Please describe.
The GTFS specification mentions in stops.stop_name:
Conditionally Required:
- Required for locations which are stops (location_type=0), stations (location_type=1) or entrances/exits (location_type=2).
- Optional for locations which are generic nodes (location_type=3) or boarding areas (location_type=4).
Describe the new validation rule
We should add a rule that would trigger a MissingStopNameNotice if:
- (
location_typehas values 0, 1 or 2) AND (stop_nameis missing) for a line instops.txt
Error vs warning ERROR
Hi @isabelle-dr
Yes, we require for stations and stops to have stop_name. A thing to note that we don't require this for entrances, do you think entrances must have a name?
Hello @asvechnikov2,
Yes, the name is also required for entrances & exits. Would you like to Pull Request the rule you have on this repo, and then we make a second PR with the additional code and use the acceptance test architecture to get the stats? We would know if there are datasets that are passing your rule and that wouldn't pass the new rule. I would be surprised if there are any since it's pretty clear in the specification.
Hello @asvechnikov2,
Yes, the name is also required for entrances & exits. Would you like to Pull Request the rule you have on this repo, and then we make a second PR with the additional code and use the acceptance test architecture to get the stats? We would know if there are datasets that are passing your rule and that wouldn't pass the new rule. I would be surprised if there are any since it's pretty clear in the specification.
@asvechnikov2 @bdferris-v2
Wanted to bump up this question. I'm able to assist with this issue as needed.
Hello @KClough, I think we can move forward with this rule. 😊 Are you still planning to write it?