gtfs-flex icon indicating copy to clipboard operation
gtfs-flex copied to clipboard

Definition Improvement of Trip Durations_NEW

Open tzujenchanmbd opened this issue 1 year ago • 5 comments

Context

PR#48 was created by @timMillet 2 years ago, and there seemed to be a consensus on the changes. However, the discussion stopped and the changes have not been merged yet. Since the old branch is 45 commits behind the current master(current flex proposal), I am creating this new PR to include [all previous proposed changes + typo revision + a tiny change based on a suggestion from comment] to the current proposal.

(side note: this PR doesn't include what we discussed on issue#73, plan to create another PR for that)

Changes in this PR include:

-Quote from PR#48

  • Better definition of the "mean" and "safe" concepts
  • Replace "travel" durations (rider-oriented) by "trip" durations (vehicle/service-oriented)
  • Define when the trip durations start and end
  • Consistency and complementarity with wait time definitions in GOFS phase 1: Service Discoverability (Draft)

-New changes

  • Revise typo (represents the average time the rider travels.....)
  • Replace "Mean" by "The mean trip duration"

For previous discussion, please see PR#48.

@timMillet @westontrillium @tsherlockcraig could you please have another look at this PR? If this looks ok we can merge to current proposal.

tzujenchanmbd avatar Jul 07 '23 15:07 tzujenchanmbd

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 07 '23 15:07 CLAassistant

lgtm!

westontrillium avatar Jul 07 '23 15:07 westontrillium

This looks like an improvement but I think that we should remove "based on historical data" from both definitions. I can see basing these factors/offsets on historical data as a best practice, but historical data won't always be available (e.g., new service, but also due to lack of data for existing services), so we shouldn't imply that it is required.

tsherlockcraig avatar Jul 10 '23 17:07 tsherlockcraig

Removed "based on historical data"

tzujenchanmbd avatar Jul 11 '23 20:07 tzujenchanmbd

@tzujenchanmbd Are you going to transfer this over to google/transit before we close this repository?

eliasmbd avatar Apr 16 '24 19:04 eliasmbd