gbfs icon indicating copy to clipboard operation
gbfs copied to clipboard

Changes to data structures

Open mplsmitch opened this issue 2 years ago • 1 comments

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

We have two fields,vehicle_type_area_capacity and vehicle_type_dock_capacity that use data from other fields as object keys. This is inconsistent with other similar fields in the specification such as vehicle_types_available and has caused some challenges in generating models and validation.

What is the proposal?

This proposal changes the objects to arrays as was done with vehicle_types _available. I've read through the rest of the specification and haven't found this issue elsewhere. If anyone is aware other examples please chime in so we can roll them into this PR.

Is this a breaking change?

  • [x] Yes
  • [ ] No
  • [ ] Unsure

Which files are affected by this change?

mplsmitch avatar Feb 07 '22 20:02 mplsmitch

This discussion has been automatically marked as stale because it has not had recent activity. It will be closed in 60 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 24 '22 02:06 stale[bot]

Entur supports this change

testower avatar Oct 12 '22 07:10 testower

@mplsmitch How can we move this forward? Call to vote?

testower avatar Oct 28 '22 12:10 testower

Hello @testower - the next step is to call a vote on this along with #454, #457 and #460 and anything else we'd like to get into the v3.0 release. In the past we've made the most progress if we group the votes an a number of issues, as opposed to holding individual votes. The PRs need to be open for comment for 7 days before a vote can be called.

I'd like to do something about #306, basically it would be like your file: https://api.entur.io/mobility/v2/gbfs/ I should be able to write it up today and get a PR open.

Great work on the Internationalization!

mplsmitch avatar Oct 28 '22 13:10 mplsmitch

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Friday, January 20th.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

josee-sabourin avatar Jan 10 '23 16:01 josee-sabourin

+1 from Transit

cmonagle avatar Jan 11 '23 15:01 cmonagle

+1 from Entur

testower avatar Jan 12 '23 10:01 testower

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: Mitch Vars
:x: mplsmitch


Mitch Vars seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 17 '23 18:01 CLAassistant

Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

josee-sabourin avatar Jan 18 '23 21:01 josee-sabourin

+1 for harmonization of data structure from nextbike

rootsixtysix avatar Jan 19 '23 14:01 rootsixtysix

+1 form Lime

kheraankit avatar Jan 19 '23 17:01 kheraankit

+1 from Joyride

benwedge avatar Jan 19 '23 20:01 benwedge

+1 from BCycle

cait32 avatar Jan 19 '23 21:01 cait32

This vote has now closed, and it passes!

Votes in favor: Transit (consumer) Entur (consumer) Nextbike (producer) Lime (producer) Joyride (producer) BCycle (producer) 
 There were no votes against. Thank you to everyone who took the time to review and to vote on this! We incorporate it into 3.0-RC, which should be ready to go in the coming week.

josee-sabourin avatar Jan 21 '23 00:01 josee-sabourin