wallet-mobile-sdk icon indicating copy to clipboard operation
wallet-mobile-sdk copied to clipboard

Update CoinbaseWalletSDK/CrossPlatform version in flutter package

Open quetool opened this issue 9 months ago • 3 comments

Summary

The current used version 1.0.4 is breaking up development cycle. See here https://github.com/reown-com/reown_flutter/issues/141

Steps to reproduce:

  • Create a new flutter project
  • Add coinbase_wallet_sdk: ^1.0.10 dependency
  • run flutter pub get
  • change ios/Podfile to define platform :ios, '13.0' on top of the file
  • run pod cache clean --all
  • run cd ios/ && pod install

Pod installation will fail with:

Mac:flutter_application_test alfreedom$ cd ios/ && pod install
Analyzing dependencies
Downloading dependencies
Installing CoinbaseWalletSDK (1.0.4)

[!] Error installing CoinbaseWalletSDK
[!] /usr/bin/git clone https://github.com/coinbase/wallet-mobile-sdk.git /var/folders/g5/dfchjsnn19gbc4c640zkj5v00000gn/T/d20250403-12241-dni7r2 --template= --single-branch --depth 1 --branch 1.0.4

Cloning into '/var/folders/g5/dfchjsnn19gbc4c640zkj5v00000gn/T/d20250403-12241-dni7r2'...
remote: Repository not found.
fatal: repository 'https://github.com/coinbase/wallet-mobile-sdk.git/' not found

Steps to fix:

  • Change coinbase_wallet_sdk: ^1.0.10 dependency with this PR url
coinbase_wallet_sdk:
  git:
    url: https://github.com/WalletConnect/wallet-mobile-sdk.git
    ref: "2.0"
    path: flutter
  • run pod cache clean --all
  • run cd ios/ && pod install

Pod installation will succeed:

Mac:flutter_application_test alfreedom$ cd ios/ && pod install
Analyzing dependencies
Downloading dependencies
Installing CoinbaseWalletSDK (1.1.0)
Installing Flutter (1.0.0)
Installing coinbase_wallet_sdk (0.0.1)
Generating Pods project
Integrating client project
Pod installation complete! There are 2 dependencies from the Podfile and 3 total pods installed.

[!] CocoaPods did not set the base configuration of your project because your project already has a custom config set. In order for CocoaPods integration to work at all, please either set the base configurations of the target `Runner` to `Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig` or include the `Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig` in your build configuration (`Flutter/Release.xcconfig`).

quetool avatar Apr 03 '25 13:04 quetool

@quetool thank you for the PR. Could you please update the PR description with how you tested/verified the fix? Thank you.

cb-jake avatar Apr 03 '25 15:04 cb-jake

@quetool thank you for the PR. Could you please update the PR description with how you tested/verified the fix? Thank you.

Done. However I believe you are using branch 2.0 to deploy flutter packages so here's the PR to that https://github.com/MobileWalletProtocol/wallet-mobile-sdk/pull/381

quetool avatar Apr 03 '25 15:04 quetool

Sent from my iPhone

kellykornflakes avatar May 18 '25 08:05 kellykornflakes