wallet-mobile-sdk icon indicating copy to clipboard operation
wallet-mobile-sdk copied to clipboard

Remove react-native-mmkv dependency

Open vishnumad opened this issue 1 year ago • 12 comments

Summary

Replace react-native-mmkv with shared preferences on Android and user defaults on iOS which fixes #199

How did you test your changes?

Handshake

https://user-images.githubusercontent.com/3137711/226071519-053d9d65-cf6f-4cb0-aa69-1ffb6b041e3c.mp4


Request

https://user-images.githubusercontent.com/3137711/226071550-2c1f916f-9e6a-40b0-8dc7-55cc01091e76.mp4


Address caching

https://user-images.githubusercontent.com/3137711/226071533-1ea9ac74-359d-409a-851e-d7c27953cc04.mp4

vishnumad avatar Mar 18 '23 00:03 vishnumad

general question: do we need any sort of data migration?

bangtoven avatar Mar 22 '23 18:03 bangtoven

@bangtoven Yeah, this will lose data for folks that were not passing in a storage object into the provider. I think we have two options:

  • Write a migration that pulls the data from the MMKV default paths (Android, iOS)
  • Or make it clear that this is a breaking change and if they were not passing in a storage object into the provider, with the new release they should pass new MMKV({ id: "mobile_sdk.store" }) in order to keep old data

vishnumad avatar Mar 23 '23 20:03 vishnumad

@vishnumad gotcha. since we don't have that many client apps yet, i think we would just go with your second option instead of implementing+maintaining migration logic

bangtoven avatar Mar 23 '23 21:03 bangtoven

@vishnumad, thanks for working on this, are there plans on landing this PR?

ikedm avatar May 01 '23 11:05 ikedm

Review Error for Chico1244 @ 2023-08-04 06:20:55 UTC User must have write permissions to review

cb-heimdall avatar Aug 04 '23 06:08 cb-heimdall

Review Error for Chico1244 @ 2023-08-04 06:45:00 UTC User must have write permissions to review

cb-heimdall avatar Aug 04 '23 06:08 cb-heimdall

Review Error for Chico1244 @ 2023-08-04 06:45:33 UTC User must have write permissions to review

cb-heimdall avatar Aug 04 '23 06:08 cb-heimdall

Review Error for Imebeez @ 2023-08-31 12:01:28 UTC User must have write permissions to review

cb-heimdall avatar Aug 31 '23 12:08 cb-heimdall

Review Error for Imebeez @ 2023-09-14 01:09:34 UTC User must have write permissions to review

cb-heimdall avatar Sep 14 '23 01:09 cb-heimdall

Will it work to recoding wallet?

Vin757 avatar Feb 10 '24 04:02 Vin757

HOW TO WITHDRAW FUNDS

TaylorMadeUSMC avatar Feb 19 '24 21:02 TaylorMadeUSMC

Thanks

Vin757 avatar Feb 21 '24 15:02 Vin757