wallet-mobile-sdk
wallet-mobile-sdk copied to clipboard
Remove react-native-mmkv dependency
Summary
Replace react-native-mmkv with shared preferences on Android and user defaults on iOS which fixes #199
How did you test your changes?
Handshake
https://user-images.githubusercontent.com/3137711/226071519-053d9d65-cf6f-4cb0-aa69-1ffb6b041e3c.mp4
Request
https://user-images.githubusercontent.com/3137711/226071550-2c1f916f-9e6a-40b0-8dc7-55cc01091e76.mp4
Address caching
https://user-images.githubusercontent.com/3137711/226071533-1ea9ac74-359d-409a-851e-d7c27953cc04.mp4
general question: do we need any sort of data migration?
@bangtoven Yeah, this will lose data for folks that were not passing in a storage object into the provider. I think we have two options:
@vishnumad gotcha. since we don't have that many client apps yet, i think we would just go with your second option instead of implementing+maintaining migration logic
@vishnumad, thanks for working on this, are there plans on landing this PR?
Review Error for Chico1244 @ 2023-08-04 06:20:55 UTC User must have write permissions to review
Review Error for Chico1244 @ 2023-08-04 06:45:00 UTC User must have write permissions to review
Review Error for Chico1244 @ 2023-08-04 06:45:33 UTC User must have write permissions to review
Review Error for Imebeez @ 2023-08-31 12:01:28 UTC User must have write permissions to review
Review Error for Imebeez @ 2023-09-14 01:09:34 UTC User must have write permissions to review
Will it work to recoding wallet?
HOW TO WITHDRAW FUNDS
Thanks