RecTools icon indicating copy to clipboard operation
RecTools copied to clipboard

Add all models tutorial links to docstrings

Open blondered opened this issue 1 year ago • 10 comments

Feature Description

Extend models docstrings in the following way:

  1. Add short description of the algorithm if necessary (examples of such short descriptions can be found in our README)
  2. Add description to scores. For example, for ALS model it could be something like: Model scores are dot products of learnt user embedding and recommended item embeddings for user-to-item recommendations. For item-to-item recommendations scores are cosine similarities between target item embedding and recommended item embeddings.

Why this feature?

Helpful for new users

Additional context

No response

blondered avatar Feb 26 '24 15:02 blondered

Hi, I would like to work on this issue, if it's still incomplete.

Saloni0512 avatar Mar 24 '24 15:03 Saloni0512

Hello! Sure, thanks. I've extended description of this issue. You can start from one model and open a draft PR with it. This way we can make sure that the form is right. And then you can continue to do descriptions to all of the models.

blondered avatar Mar 25 '24 11:03 blondered

Okay sure!

Saloni0512 avatar Mar 25 '24 18:03 Saloni0512

Hi, I wanted to ask that in which file I am supposed to add the model scores . In the docs folder, there is a models.rst file and model_selection.rst file. Which one is supposed to have the required documentation.

Saloni0512 avatar Mar 28 '24 08:03 Saloni0512

Scores descriptions are supposed to be added to models docstrings in each module

blondered avatar Mar 29 '24 10:03 blondered

I think, we are closing it since we are moving all this info to Extended Tutorial on RecSys Baselines. So it it now a duplicate

blondered avatar May 14 '24 11:05 blondered

Okay sure, is there something else I can contribute to @blondered

Saloni0512 avatar May 17 '24 11:05 Saloni0512

If you still want the same kind of issue (contributing to documentation) you can add links from each model class docstring to this model in our "Extended baselines tutorial": https://rectools.readthedocs.io/en/latest/examples/tutorials/baselines_extended_tutorial.html Correct links for each model can be found on this page: https://rectools.readthedocs.io/en/latest/tutorials.html

It this ok for you?

blondered avatar May 19 '24 18:05 blondered

Yeah sure but under which issue will I work then I mean this one is closed so. @blondered

Saloni0512 avatar May 24 '24 16:05 Saloni0512

Let's reopen it for this one for you.

blondered avatar May 24 '24 19:05 blondered