rules_xcodeproj icon indicating copy to clipboard operation
rules_xcodeproj copied to clipboard

Bug: Unable to navigate to source using Thread Performance Checker

Open erikkerber opened this issue 3 years ago • 3 comments

Describe the bug

When receiving a runtime warning using the Thread Performance Checker (i.e. "Hang Risk"), clicking on stack traces does not navigate to the source.

Example warning printed to logs:

Thread Performance Checker: Thread running at QOS_CLASS_USER_INITIATED waiting on a lower QoS thread running at QOS_CLASS_DEFAULT. Investigate ways to avoid priority inversions
PID: 92886, TID: 47811725
Backtrace
=================================================================
4   App                               0x000000010798761c $s19DraftSyncingServiceAAC15performMutation33_5ED92EF1E01BF8A8ED6B9AB9B2F5608ELL12traceContext_10PromiseKit0R0Cy10DataModels0A0V10IdentifierVG05TraceC9Interface0wQ0_pSg_yAB0A5StateVzKctFyAF8ResolverCyAMGXEfU_yycfU_ + 1016
5   App                               0x0000000105138d38 $sIeg_IeyB_TR + 48
6   libdispatch.dylib                   0x000000011b5ac594 _dispatch_call_block_and_release + 24
7   libdispatch.dylib                   0x000000011b5add5c _dispatch_client_callout + 16
8   libdispatch.dylib                   0x000000011b5b6040 _dispatch_lane_serial_drain + 928
9   libdispatch.dylib                   0x000000011b5b6d80 _dispatch_lane_invoke + 428
10  libdispatch.dylib                   0x000000011b5c4b40 _dispatch_workloop_worker_thread + 1720
11  libsystem_pthread.dylib             0x00000001ae55eb40 _pthread_wqthread + 284
12  libsystem_pthread.dylib             0x00000001ae55d904 start_wqthread + 8

As seen in the Issue navigator

CleanShot 2022-09-20 at 21 19 27@2x

Reproduction steps

  1. Generate with BwB
  2. Receive a Hang Risk
  3. Click on any stack frame, nothing happens

This works fine in BwX

Expected behavior

Clicking navigates

Versions

  • Bazel:
  • rules_xcodeproj: main (0.8+)
  • rules_apple:
  • rules_swift:

Additional context

erikkerber avatar Sep 21 '22 02:09 erikkerber

Probably a relative path issue, similar to the Test Issue navigation that we fixed. I wonder if there is something we can swizzle here to fix this in the same way.

Any thoughts @keith?

brentleyjones avatar Sep 21 '22 02:09 brentleyjones

Yea sounds like it. I've never investigated this one

keith avatar Sep 21 '22 03:09 keith

I believe @chiragramani looked into this and it doesn't look easy to fix. Care to share your findings @chiragramani?

brentleyjones avatar Oct 19 '22 13:10 brentleyjones