Store icon indicating copy to clipboard operation
Store copied to clipboard

[Feature Request] What happened to FS3 (FileSystem)?

Open laurenyew-nytimes opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Please describe. We're looking into migrating from Store4 into Store 5. What happened to FS3 (FileSystem)? We were using this regularly for a persistence solution. Is this planning to be added back or was this removed for a particular reason?

Describe the solution you'd like Documentation on migration path (if FS3 was removed, why, and suggestions on what to replace it with). If FS3 is going to be added back in, an ETA on that.

Describe alternatives you've considered We're looking into having to reimplement FS3 on our own, but if it's planning on being added back in, we don't want to duplicate work.

Additional context N/A

laurenyew-nytimes avatar Mar 09 '23 18:03 laurenyew-nytimes

Hey there - Adding FileSystem sounds fine to me. Looking at its dependencies it shouldn't be a huge lift. Happy to put it on our roadmap as long as @digitalbuddha doesn't have any concerns

matt-ramotar avatar Mar 09 '23 20:03 matt-ramotar

No concerns or compat issues. Source of truth API has not changed we just need to add the module again. Pardon the mess. I'll try to get to it early next week

digitalbuddha avatar Mar 09 '23 20:03 digitalbuddha

Just keep in mind that the FS3 implementation does not work correct using a non unix filesystem. For example https://github.com/aclassen/Store/blob/main/filesystem-kmp/src/commonMain/kotlin/com/dropbox/kmp/external/fs3/filesystem/FSFile.kt#L27 This is not true for windows , beside other limitations. @laurenyew-nytimes as long there is no offical one you can also take a look at my fork but it's Store4. I could also create a pr if needed , i updated it already to Store5

aclassen avatar Mar 23 '23 14:03 aclassen

@aclassen We need it for Android only. @digitalbuddha Has FS3 been added into this repo in Store 5?

laurenyew-nytimes avatar Mar 30 '23 17:03 laurenyew-nytimes

Hello, any results on adding filesystem to store5?

isaya-nyt avatar Jul 21 '25 13:07 isaya-nyt