FEMU icon indicating copy to clipboard operation
FEMU copied to clipboard
verified publisher icon MoatLab

Redundant else if and condition check in `nvme_process_sq_io`

Open Sober7135 opened this issue 1 year ago • 1 comments

  1. The 1 && in the if condition is unnecessary
  2. The else if (status == NVME_SUCCESS) block will never be reached.

https://github.com/MoatLab/FEMU/blob/1c2d358c1c6bc12ea38c17fb834a4470a53722e5/hw/femu/nvme-io.c#L76-L85

Sober7135 avatar Sep 05 '24 07:09 Sober7135

Yes, you're right. The code was there for debugging purposes, long time ago.

huaicheng avatar Sep 08 '24 20:09 huaicheng