Max comments

Results 387 comments of

Max

"Balanced columns" algorithm

I'm tired of rebasing all the time, so @rnmp should just tell me when he is open to use a "less bad" algorithm...

Do not call self.init() automatically

+1 for no automatic behavior, even if noobs like that :p As a workaround, I use `registerGrid` ([ahem, I mean `register_grid`](https://github.com/rnmp/salvattore/pull/45)) method when needed.

error: bundling failed: Error: While resolving module `react-native-vector-icons/FontAwesome`

It's an RN issue https://github.com/facebook/react-native/issues/17610 Will be fixed by https://github.com/facebook/react-native/pull/17672 Workaround https://github.com/oblador/react-native-vector-icons/issues/626#issuecomment-362386341

Explode features as standalone postcss plugins

You can create repo under postcss org https://github.com/postcss and make like simple packages like others postcss plugins. Do you need more explanations?

Explode features as standalone postcss plugins

This looks good yes. And you already have tests for that. That should be quick.

Explode features as standalone postcss plugins

Ok no problem :)

Explode features as standalone postcss plugins

You don't want to do this ? I see that there is nothing here https://github.com/postcss/postcss-image-set :(

Are you loading the entire lodash library?

I am seeing the same in my project I am not familiar with lodash. Who can we improve this? Source: https://github.com/th0r/webpack-bundle-analyzer

Are you loading the entire lodash library?

https://github.com/th0r/webpack-bundle-analyzer

Are you loading the entire lodash library?

I see multiple places that use lodash https://github.com/gmcquistin/react-throttle/search?utf8=✓&q=lodash I think we should directly cherry pick modules.