pihole-kubernetes
pihole-kubernetes copied to clipboard
feat!: Change yaml for Custom DNS definition + add custom.list template
Description of the change
Breaking change that will require a migration action from v2 to v3
Changed custom DNS YAML definition from:
dnsmasq.customCnameEntries:
- cname=cname.foo.bar,foo.bar
dnsmasq.customDnsEntries:
- address=/foo.bar/192.168.1.1
to:
dnsmasq.customCnameEntries:
- domain: cname.foo.bar
target: foo.bar
dnsmasq.customDnsEntries:
- domain: foo.bar
address: 192.168.1.1
The fields are named to how they're named in the GUI.
I've moved the formatting of these lines to the configmap templates.
Additionally, I added a new configmap to generate the custom.list
so the custom DNS entries show up in the GUI.
Benefits
Custom DNS entries will show up in GUI, with the additional benefit of a better readable values.yaml
Possible drawbacks
Will require users to edit their values.yaml
when upgrading from v2 to v3
Applicable issues
- fixes #191
Checklist
- [X] Variables are documented in the values.yaml they will be automatically added to README.md during deployment
- [X] Title of the pull request follows conventional commits
- [X] All commits signed off and in agreement of Developer Certificate of Origin (DCO)
Thank you for your contribution. I like this change even if it is breaking the release. I will test it on my installation. There is another breaking change in the pipeline then I'll create one new release with both changes.