SharpBucket icon indicating copy to clipboard operation
SharpBucket copied to clipboard

Bug in RepositoriesEndPoint.GetDiff() and GetPatch()?

Open asherber opened this issue 5 years ago • 3 comments

I came across this while working on #90 .

Both GetDiff() and GetPatch() take an options parameter which is an object. Looking at the API here and here I think this parameter should be called spec and should just be a string; passing in a random object will cause errors.

In addition, GetDiff() should be able to take an object like ListParameters that provides context, path, ignore_whitespace, and binary.

I can put together a PR if you agree that these should be fixed.

asherber avatar Dec 20 '18 01:12 asherber

I'm all for supporting more API calls 👍 I think that these names changed while the API evolved, thus the wrong names.

MitjaBezensek avatar Dec 20 '18 06:12 MitjaBezensek

I've got this coded, but I'm waiting on a response from Bitbucket support. The docs say that the path parameter "can be repeated for multiple paths", but I can't seem to get that to work in Postman. If I send multiple path parameters, only the last one has any effect, and sending comma or semicolon delimited values doesn't work either. I want to see if this is an error in the docs, or a bug in the API, or if there's some other way of sending multiple paths.

asherber avatar Dec 21 '18 03:12 asherber

Still going back and forth with Bitbucket support. They have acknowledged that there are some problems on their side; they said they put a fix in, but it's still not working as advertised for me.

asherber avatar Dec 25 '18 16:12 asherber