SharpBucket icon indicating copy to clipboard operation
SharpBucket copied to clipboard

Added Serilog ILogger.Debug for logging the HTTP Responses

Open anh-duc-le opened this issue 7 years ago • 3 comments

  • Upgraded the NET Framework from 4.0 => 4.5
  • Added README.md and comments for the following:

In order to run the ConsoleTests you'll first need the following:

  • You need at least 5 changesets in your repository.
  • You need at least 5 issues in your repository.
  • You need at least 1 SSH Key on your user
  • RequestExecutor.cs

    • Added ExecuteRequestWithLogging()
  • Sharpbucket.cs

    • Added Serilog ILogger overload to methods
  • EndPoint.cs

    • Added Serilog ILogger overload to methods
  • repositoriesEndPoint

    • Added Serilog ILogger overload to methods
  • Repository Resource

    • Added Serilog ILogger overload to methods.
    • Added PutRepository …
    • Added PostBranch
    • Added ListBranch
  • TeamEndPoin : Added PostProject/ ListProjects / GetProject …

  • UserEndPoint: Added GetEmails

POCOS :

  • Added :
    • Email
    • Group
    • LinkConfigurations
    • Member
    • Project
    • ProjectPostParams
  • Modified :
    • Branch
    • Branchrestriction
    • Repository
    • User

anh-duc-le avatar Apr 25 '18 14:04 anh-duc-le

It seems that you have implemented new endpoints and resources for the V2 API which is appreciated but taking a dependency on a logger like serilog is not wanted for a library like SharpBucket

Can you clean up your pull request to just the support of the new endpoints and resources ?

mnivet avatar Nov 29 '18 17:11 mnivet

Take a look at https://github.com/damianh/LibLog you are not depending on one particular logging framework then

Tanzy avatar Nov 29 '18 19:11 Tanzy

I didn't know liblog but it seems effectively a interesting solution to not expose dependency to a specific logging framework

but it's not done with that lib yet in that pull request, and I would prefer to validate separate pull requests, one for adding a log support, and one for adding support of new endpoints

mnivet avatar Nov 30 '18 10:11 mnivet