cforth
cforth copied to clipboard
simplified u.r - albeit not sure whether it can be called a simplification. It's shorter though.
penalty is more use of return stack.
Hi Mitch, I apologize for all those little annoying changes which I'd never had pushed as change request to you, agreeing with you that those are rather irrelevant. Changes to mere formatting were caused by my editor settings. I wasn't aware that those went into the original pushed change request when I synced local repo with the forked repo. You're entirely right to reject those.
Am Sat, 05 Oct 2019 01:17:51 -0700 schrieb Mitch Bradley [email protected]:
MitchBradley requested changes on this pull request.
I tried to apply the recursive version of u.r, but it doesn't work because "recurse" is defined later in the load sequence. That version of dot is only used for debugging the build. Once the problem is found, dot.fth is omitted from the build and the real versions of u.r and friends are used. I haven't used it for a very long time. It is not even loaded by default - the line that loads it in basics.fth is commented out. My version doesn't work either, due to some relatively recent changes. I fixed my version just in case. I don't see much value in optimizing it since the code never appears in a final build. How about we close this pull request and you can submit another with any fixes or improvements that you think are important.