git-interactive-rebase-tool icon indicating copy to clipboard operation
git-interactive-rebase-tool copied to clipboard

Feature Request: Custom actions on keybinds

Open dali99 opened this issue 2 years ago • 3 comments

It'd be nice to be able to bind custom keywords to binds The idea is to use it with git-revise, which adds index and cut as available actions

I've hardcoded support for those in https://github.com/dali99/git-interactive-rebase-tool but it'd be better if there was a Custom(String) action or something you could manually bind

Architecturally this seems a little complicated though

dali99 avatar Jun 06 '22 13:06 dali99

That's an interesting idea, though I agree that was the current architecture it's a bit complicated. Let me think about to integrate custom actions could work.

I do like the idea of allowing custom actions in some form.

MitMaro avatar Jun 06 '22 13:06 MitMaro

Since I'll be detecting files to tackle #739, so the easier solution might just be to explicitly support git-revise's actions when using git-revise (as it's a tool I also use 😅). It exposes a single ".git/revise.<mktemp-randomness>/git-revise-todo" file, so the same technique can be used to detect it.

forivall avatar Oct 07 '22 00:10 forivall

I can get behind that idea, of only allowing those options in the context of git-revise. Essentially, providing first-class support for git-revise when the git revise file exists, and hiding support when revise is not detected.

MitMaro avatar Oct 07 '22 12:10 MitMaro