Misty Wahl

Results 78 comments of Misty Wahl

Pushed by mistake. Converting to draft.

To do: 1. Generate data for remaining test cases for biased noise and remove script for data generation from PR (added by accident) --> should satisfy `codecov` 2. Fix types...

Marking for review since the only remaining task I'm aware of is to add tests for `eta`= 2. It takes a long time to pre-generate the data, so I thought...

> Thanks @Misty-W, nice to see this is working well! Two main comments: > > 1. The new argument `pec_data` is now used for CI tests. But do you think...

@andreamari I’m curious to hear your suggestions for hiding `pec_data` from the user. My first thought is to use something like `use_pre_executed_data: bool = False` at the top level learning...

I'm puzzled as to why `asv` is failing- it doesn't call anything I've changed.

I thought it was ready but let’s hold off for a day or so while I figure out what’s going on with the tests. Everything passed locally before my last...

@andreamari and @natestemen, ~~PR is ready for review now that tests (except for the strange error on ASV) are passing~~. PR is close to ready, but after I wrote the...

@andreamari and @natestemen, code is finally stable enough to review 😄 .

> Nice work Misty, it's cool to see this get built out and be more functional. > Thanks for the review @natestemen! > **A few comments:** > > * My...