EternalTerminal icon indicating copy to clipboard operation
EternalTerminal copied to clipboard

Added support for glob patterns (* and ?) in SSH config Include directive parser.

Open ccanoe opened this issue 8 months ago • 4 comments

I added support for glob patterns (* and ?) in the Include directive of the SSH config parser used by Eternal Terminal.

This enables the inclusion of multiple SSH config files using wildcard patterns, matching OpenSSH behavior for directives like:

Include ~/.ssh/config.d/*.conf Include host_?.conf

Tested locally with various pattern combinations and confirmed correct parsing and connection behavior.

ccanoe avatar Apr 18 '25 14:04 ccanoe

@ccanoe can you rebase and let's see if the tests pass, thanks

MisterTea avatar Jul 29 '25 09:07 MisterTea

It seems glob.h is not available on Windows, which causes a build error. I’m implementing a cross-platform alternative using filesystem and std::regex

ccanoe avatar Jul 30 '25 08:07 ccanoe

@ccanoe is this ready to review?

MisterTea avatar Oct 20 '25 17:10 MisterTea

Yes, it’s ready. I fixed the previous clang-format issue and verified the build and tests locally on macOS. It should work now.

ccanoe avatar Oct 21 '25 15:10 ccanoe

@ccanoe if you rebase, this should be good now

MisterTea avatar Dec 15 '25 19:12 MisterTea

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 79.26%. Comparing base (041ad11) to head (a865f18). :warning: Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #689   +/-   ##
=======================================
  Coverage   79.26%   79.26%           
=======================================
  Files          56       56           
  Lines        3709     3709           
  Branches      413      413           
=======================================
  Hits         2940     2940           
  Misses        769      769           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 16 '25 19:12 codecov[bot]

Thanks!

MisterTea avatar Dec 17 '25 04:12 MisterTea