EternalTerminal
EternalTerminal copied to clipboard
MisterTea
Build failure with gcc13
lib.dir/src/base/RawSocketUtils.cpp.o -c /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/RawSocketUtils.cpp
[ 79s] cc1plus: warning: /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx.gch: not used because `_FORTIFY_SOURCE' is defined [-Winvalid-pch]
[ 80s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:7,
[ 80s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.cxx:4,
[ 80s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx:4,
[ 80s] from <command-line>:
[ 80s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h: In member function 'virtual bool httplib::detail::gzip_compressor::compress(const char*, size_t, bool, httplib::detail::compressor::Callback)':
[ 80s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h:2402:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
[ 80s] 2402 | int ret = Z_OK;
[ 80s] | ^~~
[ 80s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:7,
[ 80s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.cxx:4,
[ 80s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx:4,
[ 80s] from <command-line>:
[ 80s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h: In member function 'virtual bool httplib::detail::gzip_compressor::compress(const char*, size_t, bool, httplib::detail::compressor::Callback)':
[ 80s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h:2402:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
[ 80s] 2402 | int ret = Z_OK;
[ 80s] | ^~~
[ 80s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:7,
[ 80s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.cxx:4,
[ 80s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx:4,
[ 80s] from <command-line>:
[ 80s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h: In member function 'virtual bool httplib::detail::gzip_compressor::compress(const char*, size_t, bool, httplib::detail::compressor::Callback)':
[ 80s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h:2402:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
[ 80s] 2402 | int ret = Z_OK;
[ 80s] | ^~~
[ 81s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:7,
[ 81s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.cxx:4,
[ 81s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx:4,
[ 81s] from <command-line>:
[ 81s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h: In member function 'virtual bool httplib::detail::gzip_compressor::compress(const char*, size_t, bool, httplib::detail::compressor::Callback)':
[ 81s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h:2402:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
[ 81s] 2402 | int ret = Z_OK;
[ 81s] | ^~~
[ 82s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp: In function 'int et::replaceAll(std::string&, const std::string&, const std::string&)':
[ 82s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:309:50: warning: comparison of integer expressions of different signedness: 'int' and 'const std::__cxx11::basic_string<char>::size_type' {aka 'const long unsigned int'} [-Wsign-compare]
[ 82s] 309 | while ((start_pos = str.find(from, start_pos)) != std::string::npos) {
[ 82s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
[ 82s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp: In function 'int et::replaceAll(std::string&, const std::string&, const std::string&)':
[ 82s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:309:50: warning: comparison of integer expressions of different signedness: 'int' and 'const std::__cxx11::basic_string<char>::size_type' {aka 'const long unsigned int'} [-Wsign-compare]
[ 82s] 309 | while ((start_pos = str.find(from, start_pos)) != std::string::npos) {
[ 82s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
[ 82s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp: In function 'int et::replaceAll(std::string&, const std::string&, const std::string&)':
[ 82s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:309:50: warning: comparison of integer expressions of different signedness: 'int' and 'const std::__cxx11::basic_string<char>::size_type' {aka 'const long unsigned int'} [-Wsign-compare]
[ 82s] 309 | while ((start_pos = str.find(from, start_pos)) != std::string::npos) {
[ 82s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
[ 83s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp: In function 'int et::replaceAll(std::string&, const std::string&, const std::string&)':
[ 83s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:309:50: warning: comparison of integer expressions of different signedness: 'int' and 'const std::__cxx11::basic_string<char>::size_type' {aka 'const long unsigned int'} [-Wsign-compare]
[ 83s] 309 | while ((start_pos = str.find(from, start_pos)) != std::string::npos) {
[ 83s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
[ 84s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:127:
[ 84s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/UniversalStacktrace/ust/ust.hpp: In function 'ust::StackTrace ust::generate()':
[ 84s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/UniversalStacktrace/ust/ust.hpp:407:17: warning: ignoring return value of 'char* realpath(const char*, char*)' declared with attribute 'warn_unused_result' [-Wunused-result]
[ 84s] 407 | ::realpath(fileName.c_str(), buf);
[ 84s] | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
[ 84s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:127:
[ 84s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/UniversalStacktrace/ust/ust.hpp: In function 'ust::StackTrace ust::generate()':
[ 84s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/UniversalStacktrace/ust/ust.hpp:407:17: warning: ignoring return value of 'char* realpath(const char*, char*)' declared with attribute 'warn_unused_result' [-Wunused-result]
[ 84s] 407 | ::realpath(fileName.c_str(), buf);
[ 84s] | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
[ 85s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/DaemonCreator.cpp: In static member function 'static int et::DaemonCreator::create(bool, std::string)':
[ 85s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/DaemonCreator.cpp:50:10: warning: ignoring return value of 'ssize_t write(int, const void*, size_t)' declared with attribute 'warn_unused_result' [-Wunused-result]
[ 85s] 50 | write(pidFilehandle, pid_str.c_str(), pid_str.length());
[ 85s] | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 85s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/DaemonCreator.cpp:56:8: warning: ignoring return value of 'int chdir(const char*)' declared with attribute 'warn_unused_result' [-Wunused-result]
[ 85s] 56 | chdir("/");
[ 85s] | ~~~~~^~~~~
[ 85s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:127:
...
[ 91s] /usr/bin/c++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DET_VERSION=\"6.2.4\" -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/sentry-native/include -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/easyloggingpp/src -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/ThreadPool -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/PlatformFolders -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/Catch2/single_include -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cxxopts/include -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/msgpack-c/include -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/json/single_include/nlohmann -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/sole -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/base64 -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/simpleini -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/terminal -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/terminal/forwarding -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/htm -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4 -I/home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/UniversalStacktrace/ust -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -std=c++17 -DUSE_SENTRY -DELPP_NO_DEFAULT_LOG_FILE -DELPP_FEATURE_CRASH_LOG -DELPP_THREAD_SAFE -DELPP_STRICT_PERMISSIONS -DSENTRY_BUILD_STATIC -g -ggdb3 -DWITH_UTEMPTER -O2 -g -DNDEBUG -Winvalid-pch -include /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx -std=gnu++17 -MD -MT CMakeFiles/et-lib.dir/ET.pb.cc.o -MF CMakeFiles/et-lib.dir/ET.pb.cc.o.d -o CMakeFiles/et-lib.dir/ET.pb.cc.o -c /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/ET.pb.cc
[ 91s] cc1plus: warning: /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx.gch: not used because `_FORTIFY_SOURCE' is defined [-Winvalid-pch]
[ 91s] cc1plus: warning: /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx.gch: not used because `_FORTIFY_SOURCE' is defined [-Winvalid-pch]
[ 93s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:7,
[ 93s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.cxx:4,
[ 93s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx:4,
[ 93s] from <command-line>:
[ 93s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h: In member function 'virtual bool httplib::detail::gzip_compressor::compress(const char*, size_t, bool, httplib::detail::compressor::Callback)':
[ 93s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h:2402:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
[ 93s] 2402 | int ret = Z_OK;
[ 93s] | ^~~
[ 93s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:7,
[ 93s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.cxx:4,
[ 93s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx:4,
[ 93s] from <command-line>:
[ 93s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h: In member function 'virtual bool httplib::detail::gzip_compressor::compress(const char*, size_t, bool, httplib::detail::compressor::Callback)':
[ 93s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h:2402:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
[ 93s] 2402 | int ret = Z_OK;
[ 93s] | ^~~
[ 93s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:7,
[ 93s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.cxx:4,
[ 93s] from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/build/cotire/et-lib_CXX_prefix.hxx:4,
[ 93s] from <command-line>:
[ 93s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h: In member function 'virtual bool httplib::detail::gzip_compressor::compress(const char*, size_t, bool, httplib::detail::compressor::Callback)':
[ 93s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/cpp-httplib/httplib.h:2402:9: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
[ 93s] 2402 | int ret = Z_OK;
[ 93s] | ^~~
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp: In function 'int et::replaceAll(std::string&, const std::string&, const std::string&)':
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:309:50: warning: comparison of integer expressions of different signedness: 'int' and 'const std::__cxx11::basic_string<char>::size_type' {aka 'const long unsigned int'} [-Wsign-compare]
[ 95s] 309 | while ((start_pos = str.find(from, start_pos)) != std::string::npos) {
[ 95s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp: In function 'int et::replaceAll(std::string&, const std::string&, const std::string&)':
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:309:50: warning: comparison of integer expressions of different signedness: 'int' and 'const std::__cxx11::basic_string<char>::size_type' {aka 'const long unsigned int'} [-Wsign-compare]
[ 95s] 309 | while ((start_pos = str.find(from, start_pos)) != std::string::npos) {
[ 95s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp: In function 'int et::replaceAll(std::string&, const std::string&, const std::string&)':
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:309:50: warning: comparison of integer expressions of different signedness: 'int' and 'const std::__cxx11::basic_string<char>::size_type' {aka 'const long unsigned int'} [-Wsign-compare]
[ 95s] 309 | while ((start_pos = str.find(from, start_pos)) != std::string::npos) {
[ 95s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/SubprocessToString.cpp: In function 'std::string et::SubprocessToStringInteractive(const std::string&, const std::vector<std::__cxx11::basic_string<char> >&)':
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/SubprocessToString.cpp:177:23: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<std::__cxx11::basic_string<char> >::size_type' {aka 'long unsigned int'} [-Wsign-compare]
[ 95s] 177 | for (int a = 0; a < args.size(); a++) {
[ 95s] | ~~^~~~~~~~~~~~~
[ 95s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/SubprocessToString.cpp:184:23: warning: comparison of integer expressions of different signedness: 'int' and 'std::vector<std::__cxx11::basic_string<char> >::size_type' {aka 'long unsigned int'} [-Wsign-compare]
[ 95s] 184 | for (int a = 0; a <= args.size(); a++) {
[ 95s] | ~~^~~~~~~~~~~~~~
[ 97s] In file included from /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/src/base/Headers.hpp:127:
[ 97s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/UniversalStacktrace/ust/ust.hpp: In function 'ust::StackTrace ust::generate()':
[ 97s] /home/abuild/rpmbuild/BUILD/EternalTerminal-et-v6.2.4/external_imported/UniversalStacktrace/ust/ust.hpp:407:17: warning: ignoring return value of 'char* realpath(const char*, char*)' declared with attribute 'warn_unused_result' [-Wunused-result]
[ 97s] 407 | ::realpath(fileName.c_str(), buf);
[ 97s] | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
[ 103s] [ 28%] Linking CXX static library libet-lib.a
[ 103s] /usr/bin/cmake -P CMakeFiles/et-lib.dir/cmake_clean_target.cmake
Hey! These are warnings, not errors. I'll fix, but it shouldn't block anyone from using et as-is.
The build fail was actually in the sentry 3rd party thing. We use https://build.opensuse.org/package/view_file/openSUSE:Factory/EternalTerminal/ET-gcc13.patch?expand=1 now.
Is it fixed in the latest version of sentry?
On Tue, Jun 27, 2023, 8:43 AM Michael Vetter @.***> wrote:
The build fail was actually in the sentry 3rd party thing. We use https://build.opensuse.org/package/view_file/openSUSE:Factory/EternalTerminal/ET-gcc13.patch?expand=1 now.
— Reply to this email directly, view it on GitHub https://github.com/MisterTea/EternalTerminal/issues/573#issuecomment-1609534562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACK5P7WDFQTGNHWUKTT7ADXNLPP7ANCNFSM6AAAAAAWNDTUR4 . You are receiving this because you commented.Message ID: @.***>
It's fixed with https://github.com/getsentry/breakpad/commit/7ea7ded187b4d739239f3ab7082fcd5a2ccc1eaa
@jubalh can you confirm that latest master branch builds on gcc 13? 13 isn't part of github actions yet so I can't test in CI...