GenFu icon indicating copy to clipboard operation
GenFu copied to clipboard

Corporate Names don't use the same random generator

Open GrantErickson opened this issue 9 years ago • 1 comments

We are using a deterministic random generator via an overload on the BaseValueGenerator. This allows us to run unit tests that have the same data every time. However, maybe the Corporate/Name.cs generator should use something like: return GetRandomValue(names); Rather than return names.GetRandomElement();

GetRandomElement uses a private Random generator that cannot be changed. If the intent is to use GetRandomElement, please allow for setting the Random generator using a fixed seed.

GrantErickson avatar Feb 12 '16 19:02 GrantErickson

Hey, thanks for this feedback @GrantErickson we hadn't thought of this use case. Noted and we'll look into this on our next window of time to work on this. Cheers!

MisterJames avatar Feb 18 '16 17:02 MisterJames