GenFu
GenFu copied to clipboard
Corporate Names don't use the same random generator
We are using a deterministic random generator via an overload on the BaseValueGenerator. This allows us to run unit tests that have the same data every time. However, maybe the Corporate/Name.cs generator should use something like: return GetRandomValue(names); Rather than return names.GetRandomElement();
GetRandomElement uses a private Random generator that cannot be changed. If the intent is to use GetRandomElement, please allow for setting the Random generator using a fixed seed.
Hey, thanks for this feedback @GrantErickson we hadn't thought of this use case. Noted and we'll look into this on our next window of time to work on this. Cheers!