love-release icon indicating copy to clipboard operation
love-release copied to clipboard

Empty file list should raise and error

Open ASMfreaK opened this issue 5 years ago • 3 comments

This is a somewhat following issue #39 and PR #42. The way excludeFileList works currently will somewhat fail on {''} as it is an alternative to '*' in .gitignore-like files. It excludes all files as love-release performs substring search (file:find) on a file name to exclude it and an empty string will be found in any string. Instead of erroring on empty file list, love-release fails on Mac and/or Windows with the following cryptic error message:

../env/bin/love-release -W
{
  title = 'Title',
  package = 'executable',
  loveVersion = '11.1',
  version = '0.0.1',
  author = 'Author Name',
  email = '[email protected]',
  description = nil,
  homepage = 'URL',
  identifier = 'executable',
  excludeFileList = { ''} ,
  compile = false,
  projectDirectory = '/game/',
  releaseDirectory = '/game/releases',
}
/usr/bin/lua5.1: ...e/env/share/lua/5.1/love-release/scripts/windows.lua:46: executable.love: No such file or directory
stack traceback:
	[C]: in function 'assert'
	...e/env/share/lua/5.1/love-release/scripts/windows.lua:46: in function 'release'
	...e/env/share/lua/5.1/love-release/scripts/windows.lua:80: in function <...e/env/share/lua/5.1/love-release/scripts/windows.lua:75>
	(tail call): ?
	...a-love/env/share/lua/5.1/love-release/pipes/args.lua:117: in function 'args'
	...ocks/rocks-5.1/love-release/2.0.9-1/bin/love-release:11: in main chunk
	[C]: ?

ASMfreaK avatar Dec 15 '18 16:12 ASMfreaK

Thanks for the bug report! Do you have a patch that fixes this bug? I don’t have a Mac to test it on.

MisterDA avatar Dec 16 '18 23:12 MisterDA

I don't actually know where in the codebase to fix this. Also, it is not a Mac problem. I'm sorry, I may have described the problem inaccurately. It fails not on Windows or Mac. It would fail on any platform during Windows or Mac build as with an empty file list it won't generate a .love file. The subsequent error during Windows or Mac is just a consequence of that.

ASMfreaK avatar Dec 17 '18 04:12 ASMfreaK

This seems to be fixed by PR #66 and commit 5be593f.

MisterDA avatar Jun 29 '19 13:06 MisterDA