love-release icon indicating copy to clipboard operation
love-release copied to clipboard

excluding/including files

Open Alloyed opened this issue 8 years ago • 2 comments

So #36 got me so I wanted to look through the source to figure out why and I saw this comment

-- @todo This function should be able to parse and use CVS files such as
-- gitignore. It should also work on the file tree rather than on the file list.

This is not what I'd want love-release to do, because the things I exclude from git are things like art and music that would bloat up the repo, and I don't think my game would be very good without art and music.

Possible alternate interface: have a love-release specific include/exclude list that just checks matches against normal lua patterns, so for example

t.releases.exclude = { "%.moon$" }

would exclude moonscript files and

t.releases.include = { "%.lua$", "^assets/" }

would only include either lua files or things in the assets dir

Alloyed avatar May 16 '16 22:05 Alloyed

Thanks ! This is a really good note. I didn't think about the fact you pointed out about git, and I agree with you. Your proposal on include/exclude is also a very good idea.

MisterDA avatar May 17 '16 20:05 MisterDA

Well the exclude half of this is implemented, but I can't help but notice the lack of include by pattern. Is there a reason behind that half not being implemented?

I would argue it is a good idea, I have a project where I'm excluding like 7 different file types during building, it'd be much easier to include .lua, .wav, and .png (the only file types that make up the completed game).

TangentFoxy avatar Jun 22 '18 04:06 TangentFoxy