Antonin Décimo comments

Results 287 comments of


                                            Antonin Décimo

Use macros from `limits.h` to prevent signed integer wrap-around warnigns

Rebased to fix conflicts, let me know if something can be improved.

Use macros from `limits.h` to prevent signed integer wrap-around warnigns

Gentle ping to the reviewers, how can we move forward with this PR?

Simplify `CAMLalign` and use C11 `max_align_t`

> I am not sure whether the current state of the PR corresponds to this explicit design choice. (I think it does, but in a non-obvious way.) @MisterDA, can you...

Simplify `CAMLalign` and use C11 `max_align_t`

I agree with @dustanddreams conclusions. I'd like to experiment with `aligned_alloc` in a follow-up PR, if possible.

Simplify `CAMLalign` and use C11 `max_align_t`

Unfortunately we cannot use `aligned_alloc` as the blocks can be resized. This is currently done with `realloc`, but there is no POSIX or C11 _aligned_ `realloc`. We cannot hand-roll our...

Simplify `CAMLalign` and use C11 `max_align_t`

I've added more code that uses C11 `aligned_alloc`, `free` or Microsoft `_aligned_malloc`, `_aligned_free`, `_aligned_realloc`. The default alignment of `struct pool_block` and its `data` field is now the alignment of `max_align_t`...

Simplify `CAMLalign` and use C11 `max_align_t`

@xavierleroy May I ask for another review? I hope to have addressed your concerns by switching to `aligned_alloc`.

Simplify `CAMLalign` and use C11 `max_align_t`

Thanks for the review. I've kept aligned `malloc`/`realloc`/`free` on Windows, and regular `malloc`/`realloc`/`free` on other platforms, this removed the need to keep track of the allocation size.

Updates (lwd, ocaml-ci), reformat, support cmdliner+logs+fmt

Thanks for the review, I've fixed the problems.

Optimize Dockerfile

Can't manage to make the deployer use BuildKit on itself, I'm puzzled.