curl icon indicating copy to clipboard operation
curl copied to clipboard

encoder updated twice for curl loss

Open xy9485 opened this issue 1 year ago • 2 comments

I'm looking into the code and find that in def update_cpc() both self.encoder_optimizer.step() and self.cpc_optimizer.step() are called. However the parameters of critic.encoder are carried by both optimizer. Isn't it true that, in def update_cpc(), critic.encoder is updated twice using the same gradient?

xy9485 avatar Mar 07 '23 10:03 xy9485

@xy9485 do you know why critic.encoder is updated twice in def update_cpc()?

Penelope-zhang avatar Jun 26 '23 02:06 Penelope-zhang

Yeah that's true. I don't know the reason of doing this.

LYK-love avatar Jun 18 '24 01:06 LYK-love