lambda-packages icon indicating copy to clipboard operation
lambda-packages copied to clipboard

Sasl python3.6

Open perbeatus opened this issue 7 years ago • 2 comments

Additionally for sasl package there are some .so files added to lib folder. To use them properly one must add:

os.environ['SASL_PATH'] = os.path.join(os.getcwd(), 'lib')

perbeatus avatar Mar 16 '18 17:03 perbeatus

Please merge this :)

perbeatus avatar Apr 04 '19 08:04 perbeatus

Needs README and build instructions, especially for a security package from a guy with no avatar or GH history.

Miserlou avatar Apr 04 '19 14:04 Miserlou

I think we should grant access to the querystring. Why wouldn't we?

matthewp avatar Apr 11 '21 13:04 matthewp

For a dynamic site potentially every page is dynamic. Every logged in page might display the user's name or avatar. Even the ToC and Privacy Policy pages.

Also consider that for us, we (should) be compiling static parts to strings. On a truly static page that only uses Astro components the __render() will just return a string, can't get better perf than that. Next has to deal with the cost of React components always.

matthewp avatar Apr 11 '21 14:04 matthewp

I think we're saying the same thing: when we add support for dynamic, runtime pages, then they should definitely have access to querystring. But for now, in the static-only world, granting static pages access to querystring would only be a footgun since our build command would always build the page with an empty querystring.

FredKSchott avatar Apr 11 '21 15:04 FredKSchott

Ah ok, I didn't realize this was a short term request. I'm fairly certain we're not currently adding any dynamic url or header information to the request object.

matthewp avatar Apr 11 '21 23:04 matthewp

Awesome. Would love to get @drwpow & @natemoo-re 's eyes on this to confirm there's buy-in, then would be fine to close if this isn't actionable.

FredKSchott avatar Apr 12 '21 04:04 FredKSchott

Happy to leave this open for now. I don‘t really have any thoughts on this, but it’s a good reminder of the question: “How do users expect an Astro page to behave?” In a world where we have both side-by-side, obviously. I’m not really sure, but we should have some answer to this before we get there.

drwpow avatar Apr 16 '21 20:04 drwpow

I think we have a clearer story on this now, at least until we explore dynamic pages & routes. We‘ll just start new discussions for those with new insights. Closing this for now.

drwpow avatar May 28 '21 17:05 drwpow