lambda-packages icon indicating copy to clipboard operation
lambda-packages copied to clipboard

Fix preact compat support for libraries

Open bluwy opened this issue 3 years ago • 3 comments

Changes

Fix #4093 Fix #4107

  • compat: true now noExternal-ize all react entrypoints so Vite can process and alias them to preact compat
  • Bump to Vite ^3.0.5 to bring in a fix from https://github.com/vitejs/vite/pull/9554

Testing

Added preact-compat-component test fixture to astro/test, and a sub package @test/react-lib to emulate a React library to be using preact/compat instead.

Docs

N/A

bluwy avatar Aug 09 '22 14:08 bluwy

🦋 Changeset detected

Latest commit: ed5f91cb15e9f4e355d67e0e4ba0e92e8f64a9c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
astro Patch
@astrojs/preact Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 09 '22 14:08 changeset-bot[bot]

Thanks @bluwy! We do want to continue to pin vite versions for a little while, so no ^.

Also needs a changeset.

matthewp avatar Aug 09 '22 14:08 matthewp

My bad. Added changesets and pinned Vite to 3.0.5

bluwy avatar Aug 09 '22 14:08 bluwy