Miserlou
Add support for "internal" ALBs
Context
It would be useful to enable "private" ALBs when using the ALB integration to manage requests. The use case we have is multiple private REST services that are within a VPC.
Expected Behavior
Add an option to enable private ALB schemes instead of hardcoding the value to internet-facing. To ensure backwards compatibility, still default to internet-facing.
Actual Behavior
Currently we have this value hardcoded here: https://github.com/Miserlou/Zappa/blob/master/zappa/core.py#L1345. When I manually change the value locally, it seems to work fine.
Possible Fix
I think we just need to make the scheme configurable in the ALB settings. I'm happy to make this change, I just wanted to open an issue first to ensure it's something that other people would use.
Steps to Reproduce
If this is relevant, please let me know.
Your Environment
I'm not near the system I was testing this on, but can provide these details if needed.
- Zappa version used: 0.48.2
- Operating System and Python version: Windows 10 / Python 3
- The output of
pip freeze: - Link to your project (optional):
- Your
zappa_settings.py:
Any update on this issue? There has been a PR pending since May 8 with no comment on the code. This is a feature that would be very valuable.
@mikemucc , I'm not a core contributor to this project or anything, but the linked PR seems reasonable. I no longer use this project since I switched day jobs, so someone else may be a better person to work on this / follow up...
Hello every one as Zappa support already Private API Gateway , it would be great if Zappa can support internal ALB. When do you think this PR will be accepted ?
Hello every one as Zappa support already Private API Gateway , it would be great if Zappa can support internal ALB. When do you think this PR will be accepted ?
It seems like it's available since 0.51.0, but it's not yet documented in the README in Advanced Settings.
